#include <cmath>
#include <limits>

#include "Plugin.h"
#include "Types.h"
#include "ZeekCompat.h"

#include "zeek/Desc.h"
#include "zeek/IPAddr.h"
#include "zeek/IntrusivePtr.h"
#include "zeek/RE.h"
#include "zeek/Traverse.h"
#include "zeek/Type.h"
#include "zeek/Val.h"
#include "zeek/ZeekString.h"
#include "zeek/module_util.h"

using namespace plugin::Nodejs;

namespace {

// Tracking of wrapped Zeek objects. As long as the JavaScript side object wrapping
// a Zeek side object hasn't been collected yet, we can re-use it as Zeek gives us
// the same ZeekVal pointer.
//
// Include the mask, because it's part of a wrap.
using ZeekValWrapKey = std::pair<zeek::Val*, int>;
static std::map<ZeekValWrapKey, ZeekValWrap*> wrapped_objects;

// Zeek allocated strings as external string resource to avoid copying strings into
// the JS heap. The Zeek object "owning" the string is ref'ed/unref'ed to control
// lifetime of the string. Used for StringVal and also field and enum names.
class ExternalZeekStringResource : public v8::String::ExternalOneByteStringResource {
 public:
  ExternalZeekStringResource(v8::Isolate* isolate,
                             zeek::Obj* obj,
                             const char* data,
                             int64_t length)
      : isolate_(isolate), obj_(obj), data_(data), length_(length) {
    Ref(obj_);
    isolate_->AdjustAmountOfExternalAllocatedMemory(length_);
  }

  void Dispose() override {
    dprintf("Disposing ExternalZeekString: this=%p data=%p length=%" PRId64 " obj_=%p",
            this, data_, length_, obj_);

    Unref(obj_);
    isolate_->AdjustAmountOfExternalAllocatedMemory(-length_);
    data_ = nullptr;
    length_ = 0;

    // Calls delete *this
    v8::String::ExternalOneByteStringResource::Dispose();
  }

  [[nodiscard]] const char* data() const override { return data_; }

  [[nodiscard]] size_t length() const override { return length_; };

 private:
  v8::Isolate* isolate_;
  zeek::Obj* obj_;
  const char* data_;
  int64_t length_;
};

v8::Local<v8::String> v8_str_intern(v8::Isolate* i, const char* s) {
  return v8::String::NewFromUtf8(i, s, v8::NewStringType::kInternalized)
      .ToLocalChecked();
}

v8::Local<v8::String> v8_str(v8::Isolate* i, const char* s) {
  return v8::String::NewFromUtf8(i, s).ToLocalChecked();
}

v8::Local<v8::String> v8_bytes_str(v8::Isolate* i, const char* data, int length) {
  return v8::String::NewFromOneByte(i, (const uint8_t*)data, v8::NewStringType::kNormal,
                                    length)
      .ToLocalChecked();
}

v8::Local<v8::String> v8_str_extern(v8::Isolate* i,
                                    zeek::Obj* obj,
                                    const char* data,
                                    size_t length = 0) {
#ifdef __clang_analyzer__
  // clang-tidy thinks the StringResource object is never freed,
  // hide the allocation from it.
  return v8_str(i, data);
#else
  if (length == 0)
    length = strlen(data);
  assert(length <= std::numeric_limits<int64_t>::max());
  auto res = new ExternalZeekStringResource(i, obj, data, static_cast<int64_t>(length));
  return v8::String::NewExternalOneByte(i, res).ToLocalChecked();
#endif
}

}  // namespace

ZeekValWrapper::ZeekValWrapper(v8::Isolate* isolate) : isolate_(isolate) {
  wrap_private_key_.Reset(isolate,
                          v8::Private::ForApi(isolate, v8_str("zeekjs::object::tag")));

  // Object template for records
  v8::Local<v8::ObjectTemplate> record_template = v8::ObjectTemplate::New(isolate_);
  record_template->SetInternalFieldCount(1);
  record_template->SetPrivate(GetWrapPrivateKey(isolate), v8::True(isolate),
                              v8::PropertyAttribute(v8::PropertyAttribute::DontEnum |
                                                    v8::PropertyAttribute::DontDelete |
                                                    v8::PropertyAttribute::ReadOnly));

  v8::NamedPropertyHandlerConfiguration record_conf =
      v8::NamedPropertyHandlerConfiguration(
          /*getter=*/ZeekRecordGetter,
          /*setter=*/ZeekRecordSetter,
          /*query=*/ZeekRecordQuery,
          /*deleter=*/nullptr,
          /*enumerator=*/ZeekRecordEnumerator,
          /*definer=*/nullptr,
          /*descriptor=*/nullptr,
          /*data=*/v8::Local<v8::Value>(),
          /*flags=*/v8::PropertyHandlerFlags::kHasNoSideEffect);

  record_template->SetHandler(record_conf);
  record_template_.Reset(isolate_, record_template);

  // Object template for tables
  v8::Local<v8::ObjectTemplate> table_template = v8::ObjectTemplate::New(isolate_);
  table_template->SetInternalFieldCount(1);

  v8::NamedPropertyHandlerConfiguration table_conf =
      v8::NamedPropertyHandlerConfiguration(ZeekTableGetter, ZeekTableSetter,
                                            nullptr /* query */, nullptr /* deleter */,
                                            ZeekTableEnumerator);
  table_template->SetHandler(table_conf);

  // This is insane
  v8::IndexedPropertyHandlerConfiguration table_indexed_conf =
      v8::IndexedPropertyHandlerConfiguration(ZeekTableIndexGetter,
                                              ZeekTableIndexSetter);
  table_template->SetHandler(table_indexed_conf);

  table_template_.Reset(isolate, table_template);

  // Object template for ports
  //
  // They have three internal fields representing port as number and proto
  // as string and the custom toJSON method returns just the port number.
  //
  // There's probably a less convoluted way to do that efficiently.
  v8::Local<v8::ObjectTemplate> port_template = v8::ObjectTemplate::New(isolate_);
  port_template->SetInternalFieldCount(3);

  v8::FunctionCallback toJSON_callback =
      [](const v8::FunctionCallbackInfo<v8::Value>& info) -> void {
    v8::Local<v8::Object> receiver = info.This();
    info.GetReturnValue().Set(receiver->GetInternalField(0).As<v8::Value>());
  };

  port_toJSON_function_.Reset(
      isolate_,
      v8::Function::New(isolate_->GetCurrentContext(), toJSON_callback,
                        v8::Local<v8::Value>(), 0, v8::ConstructorBehavior::kThrow,
                        v8::SideEffectType::kHasNoSideEffect)
          .ToLocalChecked());

#if (NODE_MAJOR_VERSION <= 22)
  v8::AccessorGetterCallback toJSON_cb =
      [](v8::Local<v8::String> property,
#else
  v8::AccessorNameGetterCallback toJSON_cb =
      [](v8::Local<v8::Name> property,
#endif
         const v8::PropertyCallbackInfo<v8::Value>& info) {
        info.GetReturnValue().Set(info.This()->GetInternalField(2).As<v8::Value>());
      };

  port_template->SetNativeDataProperty(
      v8_str_intern("toJSON"), toJSON_cb, nullptr, v8::Local<v8::Value>(),
      v8::PropertyAttribute(v8::PropertyAttribute::DontEnum |
                            v8::PropertyAttribute::ReadOnly),
#if (NODE_MAJOR_VERSION <= 22)
      v8::AccessControl::DEFAULT,
#endif
      v8::SideEffectType::kHasNoSideEffect);

#if (NODE_MAJOR_VERSION <= 22)
  v8::AccessorGetterCallback port_cb =
      [](v8::Local<v8::String> property,
#else
  v8::AccessorNameGetterCallback port_cb =
      [](v8::Local<v8::Name> property,
#endif
         const v8::PropertyCallbackInfo<v8::Value>& info) {
        info.GetReturnValue().Set(info.This()->GetInternalField(0).As<v8::Value>());
      };

  port_template->SetNativeDataProperty(v8_str_intern("port"), port_cb, nullptr,
                                       v8::Local<v8::Value>(),
                                       v8::PropertyAttribute::ReadOnly,
#if (NODE_MAJOR_VERSION <= 22)
                                       v8::AccessControl::DEFAULT,
#endif
                                       v8::SideEffectType::kHasNoSideEffect);

#if (NODE_MAJOR_VERSION <= 22)
  v8::AccessorGetterCallback proto_cb =
      [](v8::Local<v8::String> property,
#else
  v8::AccessorNameGetterCallback proto_cb =
      [](v8::Local<v8::Name> property,
#endif
         const v8::PropertyCallbackInfo<v8::Value>& info) {
        info.GetIsolate();
        info.GetReturnValue().Set(info.This()->GetInternalField(1).As<v8::Value>());
      };

  port_template->SetNativeDataProperty(v8_str_intern("proto"), proto_cb, nullptr,
                                       v8::Local<v8::Value>(),
                                       v8::PropertyAttribute::ReadOnly,
#if (NODE_MAJOR_VERSION <= 22)
                                       v8::AccessControl::DEFAULT,
#endif
                                       v8::SideEffectType::kHasNoSideEffect);
  port_template_.Reset(isolate_, port_template);

  port_str_.Reset(isolate, v8_str_intern("port"));
  proto_str_.Reset(isolate, v8_str_intern("proto"));
  toJSON_str_.Reset(isolate, v8_str_intern("toJSON"));

  transport_proto_str_map_[TRANSPORT_UNKNOWN].Reset(isolate_, v8_str_intern("unknown"));
  transport_proto_str_map_[TRANSPORT_TCP].Reset(isolate_, v8_str_intern("tcp"));
  transport_proto_str_map_[TRANSPORT_UDP].Reset(isolate_, v8_str_intern("udp"));
  transport_proto_str_map_[TRANSPORT_ICMP].Reset(isolate_, v8_str_intern("icmp"));
}

void ZeekValWrapper::init_record_infos(const zeek::RecordTypePtr& rt) {
  v8::Local<v8::Context> context = isolate_->GetCurrentContext();
  IdentityHashOffsetMap ih_map;
  NameOffsetMap n_map;
  std::set<int> hash_collisions;
  std::array<v8::Local<v8::Array>, 2> v8_field_names;

  // Grumble: I'm not sure this will scale, but maybe we only ever
  // have attribute log filtering and anything else is irrelevant
  // (or we do not support oring together).
  v8_field_names[ZEEKJS_ATTR_NONE] = v8::Array::New(isolate_);
  v8_field_names[ZEEKJS_ATTR_LOG] = v8::Array::New(isolate_);

  for (int offset = 0; offset < rt->NumFields(); offset++) {
    const zeek::TypeDecl* const field_decl = rt->FieldDecl(offset);
    std::string field_name = field_decl->id;
    v8::Local<v8::String> v8_field_name = v8_str_intern(field_name.c_str());
    int hash = v8_field_name->GetIdentityHash();
    if (ih_map.count(hash) == 0) {
      ih_map[hash] = offset;
    } else {
      dprintf("collision %s %s for %s", field_name.c_str(), rt->FieldName(ih_map[hash]),
              rt->GetName().c_str());
      hash_collisions.insert(hash);
    }

    n_map[field_name] = offset;

    v8_field_names[ZEEKJS_ATTR_NONE]->Set(context, offset, v8_field_name).Check();
    if (field_decl->GetAttr(zeek::detail::ATTR_LOG))
      v8_field_names[ZEEKJS_ATTR_LOG]
          ->Set(context, v8_field_names[ZEEKJS_ATTR_LOG]->Length(), v8_field_name)
          .Check();
  }

  // Put toJSON with an offset of -1 so that lookups for it fail quickly.
  static std::vector<std::string> no_offsets = {"toJSON", "toString"};
  for (const auto& s : no_offsets) {
    auto v8_str = v8::String::NewFromOneByte(
                      isolate_, reinterpret_cast<const uint8_t*>(s.c_str()))
                      .ToLocalChecked();
    int hash = v8_str->GetIdentityHash();
    if (ih_map.count(hash) == 0) {
      ih_map[hash] = -1;
    } else {
      hash_collisions.insert(hash);
    }

    n_map[s] = -1;
  }

  // If there were any hash collisions, clear them.
  for (const auto& hash : hash_collisions)
    ih_map.erase(hash);

  RecordTypeInfo info{
      .ih_map = std::move(ih_map),
      .n_map = std::move(n_map),
  };
  info.v8_field_names[ZEEKJS_ATTR_NONE].Reset(isolate_,
                                              v8_field_names[ZEEKJS_ATTR_NONE]);
  info.v8_field_names[ZEEKJS_ATTR_LOG].Reset(isolate_, v8_field_names[ZEEKJS_ATTR_LOG]);

  record_info_cache_.insert({rt, std::move(info)});
}

int ZeekValWrapper::GetRecordFieldOffset(const zeek::RecordTypePtr& rt,
                                         const v8::Local<v8::Name>& property) {
  const auto& it = record_info_cache_.find(rt);
  if (it == record_info_cache_.end()) {
    init_record_infos(rt);
    return GetRecordFieldOffset(rt, property);
  }

  const auto& info = it->second;
  int identity_hash = property->GetIdentityHash();

  if (const auto& ih_it = info.ih_map.find(identity_hash); ih_it != info.ih_map.end()) {
    return ih_it->second;
  }

  // Slow path: Make a string out of the property and look it up in the name map and
  // if it's not there, then someone tried to get something that just doesn't exist.
  v8::String::Utf8Value property_val(isolate_, property);
  dprintf("fallback for %s %s\n", rt->GetName().c_str(), *property_val);

  if (*property_val) {
    std::string property_str(*property_val);
    dprintf("Fallback via string %s::%s (%d)\n", rt->GetName().c_str(),
            property_str.c_str(), identity_hash);
    if (const auto& n_it = info.n_map.find(property_str); n_it != info.n_map.end()) {
      return n_it->second;
    }
  }

  return -1;
}

v8::Local<v8::Array> ZeekValWrapper::GetRecordFieldNames(const zeek::RecordTypePtr& rt,
                                                         int attr_mask) {
  const auto& it = record_info_cache_.find(rt);
  if (it == record_info_cache_.end()) {
    init_record_infos(rt);
    return GetRecordFieldNames(rt, attr_mask);
  }
  return it->second.v8_field_names[attr_mask].Get(isolate_);
}

v8::Local<v8::BigInt> ZeekValWrapper::GetBigInt(zeek_uint_t v) {
  if (persistent_bigints_.size() < v)
    return v8::BigInt::NewFromUnsigned(isolate_, v);

  v8::Persistent<v8::BigInt>& entry = persistent_bigints_[v];
  if (!entry.IsEmpty())
    return entry.Get(isolate_);

  auto v8_v = v8::BigInt::NewFromUnsigned(isolate_, v);
  entry.Reset(isolate_, v8_v);
  return v8_v;
}

v8::Local<v8::Object> ZeekValWrapper::WrapAsObject(const zeek::ValPtr& vp,
                                                   int attr_mask) {
  const ZeekValWrapKey k{vp.get(), attr_mask};
  if (auto const& it = ::wrapped_objects.find(k); it != ::wrapped_objects.end()) {
    return it->second->GetHandle(isolate_);
  }

  v8::Local<v8::Context> context = isolate_->GetCurrentContext();
  // Note, with opaque and zeek.as() the record_template is also
  // used for non-record types. It might make sense to have type
  // specific templates in the future.
  v8::Local<v8::ObjectTemplate> tmpl = record_template_.Get(isolate_);
  v8::Local<v8::Object> obj = tmpl->NewInstance(context).ToLocalChecked();
  ZeekValWrap* wrap = ZeekValWrap::Make(isolate_, this, obj, vp->Ref(), attr_mask);
  return wrap->GetHandle(isolate_);
}

v8::Local<v8::Value> ZeekValWrapper::wrap_port(const zeek::ValPtr& vp) {
  zeek::PortVal* pvp = vp->AsPortVal();

  int cache_idx =
      static_cast<int>(pvp->PortType()) * 65536 + static_cast<int>(pvp->Port());
  if (!port_cache_[cache_idx].IsEmpty()) {
    return port_cache_[cache_idx].Get(isolate_);
  }

  v8::Local<v8::Context> context = isolate_->GetCurrentContext();
  v8::Local<v8::Object> obj =
      port_template_.Get(isolate_)->NewInstance(context).ToLocalChecked();

  v8::Local<v8::Number> port = v8::Number::New(isolate_, pvp->Port());
  v8::Local<v8::String> proto =
      transport_proto_str_map_.at(pvp->PortType()).Get(isolate_);

  obj->SetInternalField(0, port);
  obj->SetInternalField(1, proto);
  obj->SetInternalField(2, port_toJSON_function_.Get(isolate_));

  port_cache_[cache_idx].Reset(isolate_, obj);

  return obj;
}

v8::Local<v8::Value> ZeekValWrapper::wrap_string(const zeek::ValPtr& vp) {
  auto sv = vp->AsStringVal();
  int len = sv->Len();
  if (len == 0)
    return v8::String::Empty(isolate_);

  auto data = reinterpret_cast<const char*>(sv->Bytes());

  // If we could figure out here that this is actually a
  // conn uid, we may be able to pass a hint to internalize
  // the string so that it's de-duplicated :-/
  if (len <= 1024)
    return ::v8_bytes_str(isolate_, data, len);

  return v8_str_extern(isolate_, sv, data, len);
}

v8::Local<v8::Value> ZeekValWrapper::wrap_vector(const zeek::ValPtr& vp) {
  // Hmm, hmm, maybe we could make this lazy and not
  // construct the full array.
  zeek::VectorVal* vv = vp->AsVectorVal();

  // Could fix, but for now error and return undefined..
  if (vv->Size() > INT_MAX) {
    eprintf("Too many entries in vector: %u", vv->Size());
    return v8::Undefined(isolate_);
  }
  auto size = static_cast<int>(vv->Size());
  std::vector<v8::Local<v8::Value>> elements;
  elements.reserve(size);
  for (int i = 0; i < size; i++) {
    const zeek::ValPtr& vp = vv->ValAt(i);
    elements.emplace_back(Wrap(vp));
  }
  return v8::Array::New(isolate_, elements.data(), size);
}

v8::Local<v8::Value> ZeekValWrapper::wrap_table(const zeek::ValPtr& vp) {
  v8::Local<v8::Context> context = isolate_->GetCurrentContext();
  zeek::TableVal* tval = vp->AsTableVal();
  // dprintf("Table tval=%p", tval);
  if (tval->GetType()->IsSet()) {
    zeek::TableTypePtr tt = tval->GetType<zeek::TableType>();
    auto index_size = tt->GetIndexTypes().size();
    zeek::ListValPtr lv = tval->ToListVal();

    // Set of functions: return null for backwards compat
    if (index_size == 1 && tt->GetIndexTypes()[0]->Tag() == zeek::TYPE_FUNC)
      return v8::Null(isolate_);

    // For expedience, at this point, a set is
    // simply converted to an array. There's Set()
    // but that's not JSON stringify'ble, so...
    auto size = lv->Length();
    v8::Local<v8::Array> array = v8::Array::New(isolate_, size);
    for (int i = 0; i < size; i++) {
      auto& v = lv->Idx(i);
      if (index_size == 1)
        array->Set(context, i, Wrap(v->AsListVal()->Idx(0))).Check();
      else
        array->Set(context, i, Wrap(v)).Check();
    }
    return array;
  } else {
    // Note, if the table has multiple indices, we still wrap it and
    // pass it through to JavaScript so it can be threaded back to Zeek.
    // Lookups or enumerating such tables will throw exceptions, however.
    v8::Local<v8::ObjectTemplate> tmpl = table_template_.Get(isolate_);
    v8::Local<v8::Object> obj = tmpl->NewInstance(context).ToLocalChecked();

    ZeekValWrap* wrap = ZeekValWrap::Make(isolate_, this, obj, tval->Ref());
    return wrap->GetHandle(isolate_);
  }
}

v8::Local<v8::Value> ZeekValWrapper::wrap_enum(const zeek::ValPtr& vp) {
  zeek::EnumVal* ev = vp->AsEnumVal();
  zeek::EnumType* et = vp->GetType()->AsEnumType();
  const char* name = et->Lookup(ev->AsEnum());
  return v8_str_extern(isolate_, et, name);
}

v8::Local<v8::Value> ZeekValWrapper::wrap_pattern(const zeek::ValPtr& vp) {
  const zeek::RE_Matcher* re = vp->AsPatternVal()->AsPattern();
  return v8_str(re->PatternText());
}

v8::Local<v8::Value> ZeekValWrapper::Wrap(const zeek::ValPtr& vp, int attr_mask) {
  // For nil/empty, return undefined. Expect the caller to figure
  // out if this is the right value. E.g. for void functions.
  if (vp == zeek::Val::nil)
    return v8::Undefined(isolate_);

  zeek::TypeTag tag = vp->GetType()->Tag();

  switch (tag) {
    case zeek::TYPE_BOOL:
      return v8::Boolean::New(isolate_, vp->CoerceToInt() ? true : false);
    case zeek::TYPE_COUNT:
      return GetBigInt(vp->AsCount());
    case zeek::TYPE_INT:
      // Grml, this may be lossy, but making it a bigint: annoying.
      return v8::Number::New(isolate_, static_cast<double>(vp->AsInt()));
    case zeek::TYPE_DOUBLE:
      return v8::Number::New(isolate_, vp->AsDouble());
    case zeek::TYPE_INTERVAL:
      return v8::Number::New(isolate_, vp->AsInterval());
    case zeek::TYPE_TIME:
      return v8::Number::New(isolate_, vp->AsTime());
    case zeek::TYPE_STRING:
      return wrap_string(vp);
    case zeek::TYPE_ADDR:
      return v8_str(vp->AsAddr().AsString().c_str());
    case zeek::TYPE_SUBNET:
      return v8_str(vp->AsSubNet().AsString().c_str());
    case zeek::TYPE_PORT:
      return wrap_port(vp);
    case zeek::TYPE_RECORD:
      return WrapAsObject(vp, attr_mask);
    case zeek::TYPE_VECTOR:
      return wrap_vector(vp);
    case zeek::TYPE_TABLE:
      return wrap_table(vp);
    case zeek::TYPE_ENUM:
      return wrap_enum(vp);
    case zeek::TYPE_PATTERN:
      return wrap_pattern(vp);
    case zeek::TYPE_OPAQUE:
      return WrapAsObject(vp);
    case zeek::TYPE_LIST: {  // types (?)
      v8::Local<v8::Context> context = isolate_->GetCurrentContext();
      zeek::ListVal* lval = vp->AsListVal();
      int size = lval->Length();
      v8::Local<v8::Array> array = v8::Array::New(isolate_, size);
      for (int i = 0; i < size; i++)
        array->Set(context, i, Wrap(lval->Idx(i))).Check();

      return array;
    }

    default:
      eprintf("Unhandled type tag %s (%d), returning null", zeek::type_name(tag), tag);
      return v8::Null(isolate_);
  }
}

bool ZeekValWrapper::Unwrap(v8::Isolate* isolate,
                            v8::Local<v8::Object> obj,
                            ZeekValWrap** wrap) {
  v8::Local<v8::Context> context = isolate_->GetCurrentContext();
  if (!obj->HasPrivate(context, GetWrapPrivateKey(isolate)).ToChecked())
    return false;

  *wrap = static_cast<ZeekValWrap*>(obj->GetAlignedPointerFromInternalField(0));

  return true;
}

// Convert a Javascript value over to a zeek::ValPtr using the given type.
//
// TODO: Refactor.
ZeekValWrapper::Result ZeekValWrapper::ToZeekVal(v8::Local<v8::Value> v8_val,
                                                 const zeek::TypePtr& type) {
  ZeekValWrapper::Result wrap_result = {.ok = true};
  v8::Local<v8::Context> context = isolate_->GetCurrentContext();
  zeek::TypeTag type_tag = type->Tag();

#ifdef DEBUG
  v8::Local<v8::String> typeof_str = v8_val->TypeOf(isolate_);
  v8::String::Utf8Value typeof_utf8(isolate_, typeof_str);
  dprintf("type tag %d/%s val=%s (%s)", type_tag, zeek::type_name(type_tag),
          *v8::String::Utf8Value(isolate_, v8_val), *typeof_utf8);
#endif

  // Pass-through fast-path: If this is an object and it's backed by
  // a ZeekValWrap of the same type, just thread it through directly.
  if (v8_val->IsObject()) {
    auto obj = v8::Local<v8::Object>::Cast(v8_val);
    ZeekValWrap* zeek_val_wrap = nullptr;
    if (Unwrap(isolate_, obj, &zeek_val_wrap)) {
      zeek::Val* vp = zeek_val_wrap->GetVal();
      if (type_tag == zeek::TYPE_ANY || type_tag == zeek::TYPE_OPAQUE ||
          vp->GetType()->Tag() == type_tag) {
        wrap_result.val = {zeek::NewRef{}, vp};
        return wrap_result;
      }

      // Give up if the tag disagreed.
      wrap_result.ok = false;
      wrap_result.error = zeek::util::fmt("ZeekValWrap pass-through bad tags: %d != %d",
                                          vp->GetType()->Tag(), type_tag);
      return wrap_result;
    }
  }

  if (type_tag == zeek::TYPE_BOOL && v8_val->IsBoolean()) {
    wrap_result.val = zeek::val_mgr->Bool(v8_val->IsTrue());
    return wrap_result;
  } else if (type_tag == zeek::TYPE_ADDR) {
    v8::Local<v8::String> v8_str = v8_val->ToString(context).ToLocalChecked();
    v8::String::Utf8Value utf8_value(isolate_, v8_str);
    in6_addr addr6;

    if (zeek::IPAddr::ConvertString(*utf8_value, &addr6)) {
      wrap_result.val = zeek::make_intrusive<zeek::AddrVal>(zeek::IPAddr(addr6));
      return wrap_result;
    }
  } else if (type_tag == zeek::TYPE_SUBNET) {
    v8::Local<v8::String> v8_str = v8_val->ToString(context).ToLocalChecked();
    v8::String::Utf8Value utf8_value(isolate_, v8_str);
    zeek::IPPrefix ip_prefix;

    if (zeek::IPPrefix::ConvertString(*utf8_value, &ip_prefix)) {
      wrap_result.val = zeek::make_intrusive<zeek::SubNetVal>(ip_prefix);
      return wrap_result;
    } else {
      // Ad-hoc support for the bracketed IPv6 subnet notation as well.
      // For example, [2607:f8b0::]/40.
      if ((*utf8_value)[0] == '[') {
        std::string cleaned = *utf8_value;
        cleaned.erase(0, 1);
        size_t loc = cleaned.find("]/");
        if (loc != std::string::npos) {
          cleaned.erase(loc, 1);
          if (zeek::IPPrefix::ConvertString(cleaned.c_str(), &ip_prefix)) {
            wrap_result.val = zeek::make_intrusive<zeek::SubNetVal>(ip_prefix);
            return wrap_result;
          }
        }
      }
    }
  } else if (type_tag == zeek::TYPE_PATTERN) {
    if (v8_val->IsString()) {
      // Convert a JS string to a pattern
      v8::Local<v8::String> v8_str = v8_val->ToString(context).ToLocalChecked();
      v8::String::Utf8Value utf8_value(isolate_, v8_str);

      auto re = std::make_unique<zeek::RE_Matcher>(*utf8_value);
      if (!re->Compile(false)) {
        wrap_result.ok = false;
        wrap_result.error = "Unable to compile pattern";
        return wrap_result;
      }

      wrap_result.val = zeek::make_intrusive<zeek::PatternVal>(re.release());
      return wrap_result;
    }

  } else if (type_tag == zeek::TYPE_PORT) {
    // If this is an object, look for "port" and "proto" fields and interpret them.
    // This allows forth and back conversion between Zeek and Javascript
    if (v8_val->IsObject()) {
      auto obj = v8::Local<v8::Object>::Cast(v8_val);
      auto maybe_port = obj->Get(context, port_str_.Get(isolate_));
      auto maybe_proto = obj->Get(context, proto_str_.Get(isolate_));

      v8::Local<v8::Value> port_val = maybe_port.ToLocalChecked();
      v8::Local<v8::Value> proto_val = maybe_proto.ToLocalChecked();
      if (!port_val->IsNumber() || !proto_val->IsString()) {
        wrap_result.ok = false;
        wrap_result.error =
            "Missing property or bad type for port (number) or proto (string)";
        return wrap_result;
      }

      uint32_t port = port_val->ToUint32(context).ToLocalChecked()->Value();
      v8::String::Utf8Value proto_utf8_value(isolate_, proto_val);
      TransportProto proto = TRANSPORT_UNKNOWN;
      if (!strcmp("tcp", *proto_utf8_value)) {
        proto = TRANSPORT_TCP;
      } else if (!strcmp("udp", *proto_utf8_value)) {
        proto = TRANSPORT_UDP;
      } else if (!strcmp("icmp", *proto_utf8_value)) {
        proto = TRANSPORT_ICMP;
      }
      wrap_result.val = zeek::val_mgr->Port(port, proto);
      return wrap_result;
    }
  } else if (type_tag == zeek::TYPE_COUNT) {
    if (v8_val->IsNumber()) {
      double dresult = v8_val->NumberValue(context).ToChecked();

      // If this is a positive number, convert it to a double, then cast
      // to a zeek_uint_t for the val manager. Convert the unsigned
      // int to a double before to see if we get the same result,
      // otherwise report precision loss.
      //
      // NOTE: This is subtracting 2048 from zeek_uint_t's max value
      // to avoid platform specific differences when casting between
      // zeek_uint_t and double on Linux vs OSX when close at the limit.
      //
      // If you understand, patches certainly welcome to remove the 2048!
      if (std::isfinite(dresult) &&
          dresult <=
              static_cast<double>(std::numeric_limits<zeek_uint_t>::max() - 2048) &&
          dresult >= 0.0) {
        auto result = static_cast<zeek_uint_t>(dresult);
        auto diresult = static_cast<double>(result);
        // No fractional part?
        if (dresult == diresult) {
          wrap_result.val = zeek::val_mgr->Count(result);
        } else {
          v8::String::Utf8Value val_utf8(isolate_, v8_val);
          wrap_result.ok = false;
          wrap_result.error =
              zeek::util::fmt("precision loss going from %s to count", *val_utf8);
        }

        return wrap_result;
      }
    } else if (v8_val->IsBigInt()) {
      bool lossless = true;
      auto bigint = v8_val->ToBigInt(context).ToLocalChecked();
      zeek_uint_t result = bigint->Uint64Value(&lossless);

      if (lossless) {
        wrap_result.val = zeek::val_mgr->Count(result);
        return wrap_result;
      } else {
        v8::String::Utf8Value val_utf8(isolate_, v8_val);
        wrap_result.ok = false;
        wrap_result.error =
            zeek::util::fmt("precision loss going from %s to count", *val_utf8);
        return wrap_result;
      }
    }

    // Generic error
    wrap_result.ok = false;
    v8::String::Utf8Value val_utf8(isolate_, v8_val);
    wrap_result.error = zeek::util::fmt(
        "'%s' not a number or bigint or out of range for count", *val_utf8);
    return wrap_result;
  } else if (type_tag == zeek::TYPE_INT) {
    if (v8_val->IsNumber()) {
      double dresult = v8_val->NumberValue(context).ToChecked();

      if (std::isfinite(dresult) &&
          dresult <= static_cast<double>(std::numeric_limits<zeek_int_t>::max()) &&
          dresult >= static_cast<double>(std::numeric_limits<zeek_int_t>::min())) {
        // Cast to zeek_int_t, then cast once more to double and
        // compare to the original input. If there was any loss,
        // fail the conversion.
        zeek_int_t result = v8_val->IntegerValue(context).ToChecked();
        auto diresult = static_cast<double>(result);

        if (dresult == diresult) {
          wrap_result.val = zeek::val_mgr->Int(result);
        } else {
          v8::String::Utf8Value val_utf8(isolate_, v8_val);
          wrap_result.ok = false;
          wrap_result.error =
              zeek::util::fmt("precision loss going from %s to int", *val_utf8);
        }

        return wrap_result;
      }
    } else if (v8_val->IsBigInt()) {
      // Try BigInt to int for convenience, but fail if it is too large.
      bool lossless = true;
      auto bigint = v8_val->ToBigInt(context).ToLocalChecked();
      zeek_int_t result = bigint->Int64Value(&lossless);

      if (lossless) {
        wrap_result.val = zeek::val_mgr->Count(result);
      } else {
        v8::String::Utf8Value val_utf8(isolate_, v8_val);
        wrap_result.ok = false;
        wrap_result.error =
            zeek::util::fmt("precision loss going from %s to int", *val_utf8);
      }

      return wrap_result;
    }

    wrap_result.ok = false;
    v8::String::Utf8Value val_utf8(isolate_, v8_val);
    wrap_result.error = zeek::util::fmt(
        "'%s' not a number or bigint or out of range for int", *val_utf8);
    return wrap_result;
  } else if (type_tag == zeek::TYPE_DOUBLE) {
    if (v8_val->IsNumber()) {
      v8::Maybe<double> result = v8_val->NumberValue(context);
      wrap_result.val =
          plugin::Corelight_ZeekJS::compat::DoubleVal_New(result.ToChecked());
      return wrap_result;
    }
  } else if (type_tag == zeek::TYPE_TIME) {
    if (v8_val->IsNumber()) {
      double ts = v8_val->NumberValue(context).ToChecked();
      wrap_result.val = plugin::Corelight_ZeekJS::compat::TimeVal_New(ts);
      return wrap_result;
    } else if (v8_val->IsDate()) {
      double ts = v8::Local<v8::Date>::Cast(v8_val)->ValueOf() / 1000.0;
      wrap_result.val = plugin::Corelight_ZeekJS::compat::TimeVal_New(ts);
      return wrap_result;
    }
  } else if (type_tag == zeek::TYPE_INTERVAL) {
    if (v8_val->IsNumber()) {
      double interval = v8_val->NumberValue(context).ToChecked();
      wrap_result.val = plugin::Corelight_ZeekJS::compat::IntervalVal_New(interval);
      return wrap_result;
    }
  } else if (type_tag == zeek::TYPE_STRING) {
    if (v8_val->IsString()) {
      // TODO/XXX: Don't do UTF8 encoding here, just treat it as binary blob.
      // Look at WriteOneByte(), but need to allocate a buffer.
      v8::Local<v8::String> v8_string = v8::Local<v8::String>::Cast(v8_val);
      v8::String::Utf8Value utf8_value(isolate_, v8_string);
      wrap_result.val = zeek::make_intrusive<zeek::StringVal>(*utf8_value);
      return wrap_result;
    }

  } else if (type_tag == zeek::TYPE_ENUM) {
    zeek::EnumType* enum_type = type->AsEnumType();
    v8::Local<v8::String> v8_str = v8_val->ToString(context).ToLocalChecked();
    v8::String::Utf8Value utf8_value(isolate_, v8_str);

    std::string module_name = zeek::detail::extract_module_name(*utf8_value);
    std::string var_name = zeek::detail::extract_var_name(*utf8_value);
    zeek_int_t enum_int = enum_type->Lookup(module_name, var_name.c_str());
    if (enum_int >= 0) {
      wrap_result.val = enum_type->GetEnumVal(enum_int);
    } else {
      dprintf("Failed to resolve enum %s", *utf8_value);
      wrap_result.ok = false;
      wrap_result.error =
          std::string("Enum value ") + *utf8_value + std::string(" unknown");
    }
    return wrap_result;

  } else if (type_tag == zeek::TYPE_VECTOR) {
    if (!v8_val->IsArray()) {
      wrap_result.ok = false;
      wrap_result.error = "Expected JS type array for Zeek type vector";
    } else {
      v8::Local<v8::Array> v8_array = v8::Local<v8::Array>::Cast(v8_val);
      std::vector<zeek::ValPtr> vals(v8_array->Length());

      for (uint32_t i = 0; i < v8_array->Length(); i++) {
        v8::Local<v8::Value> v8_element_value =
            v8_array->Get(context, i).ToLocalChecked();

        ZeekValWrapper::Result element_result =
            ToZeekVal(v8_element_value, type->Yield());
        if (!element_result.ok) {
          wrap_result.ok = false;
          wrap_result.error +=
              zeek::util::fmt("Error with array element at index %u: %s", i,
                              element_result.error.c_str());
          return wrap_result;
        }

        vals[i] = element_result.val;
      }

      zeek::VectorTypePtr vector_type = {zeek::NewRef{}, type->AsVectorType()};
      zeek::VectorValPtr vvp = zeek::make_intrusive<zeek::VectorVal>(vector_type);

      for (const auto& v : vals)
        vvp->Append(v);

      wrap_result.val = vvp;
      return wrap_result;
    }

    return wrap_result;
  } else if (type_tag == zeek::TYPE_TABLE) {
    zeek::TableTypePtr table_type = {zeek::NewRef{}, type->AsTableType()};
    const std::vector<zeek::TypePtr>& itypes = table_type->GetIndexTypes();
    // No support for compund indices.
    if (itypes.size() != 1) {
      wrap_result.ok = false;
      wrap_result.error = zeek::util::fmt("Unsupported index size %lu for type %s",
                                          itypes.size(), type->GetName().c_str());
      return wrap_result;
    }

    if (table_type->IsSet()) {
      if (v8_val->IsArray() || v8_val->IsSet()) {
        zeek::TableValPtr table_val = zeek::make_intrusive<zeek::TableVal>(table_type);
        v8::Local<v8::Array> v8_array;
        if (v8_val->IsArray())
          v8_array = v8::Local<v8::Array>::Cast(v8_val);
        else
          v8_array = v8::Local<v8::Set>::Cast(v8_val)->AsArray();

        // Okay we have an array, just convert it over to index type of the set.
        for (uint32_t i = 0; i < v8_array->Length(); i++) {
          ZeekValWrapper::Result index_result =
              ToZeekVal(v8_array->Get(context, i).ToLocalChecked(), itypes[0]);

          if (!index_result.ok) {
            wrap_result.ok = false;
            wrap_result.error =
                zeek::util::fmt("Error with array element at index %u: %s", i,
                                index_result.error.c_str());
            return wrap_result;
          }
          table_val->Assign(index_result.val, zeek::Val::nil);
        }
        wrap_result.val = std::move(table_val);
        return wrap_result;
      }
    } else {
      if (v8_val->IsObject()) {
        zeek::TableValPtr table_val = zeek::make_intrusive<zeek::TableVal>(table_type);
        zeek::TypePtr yield_type = type->Yield();
        v8::Local<v8::Object> v8_obj = v8::Local<v8::Object>::Cast(v8_val);

        v8::Local<v8::Array> v8_names =
            v8_obj->GetOwnPropertyNames(context).ToLocalChecked();

        for (uint32_t i = 0; i < v8_names->Length(); i++) {
          // Property name to Zeek Val
          v8::Local<v8::Value> key = v8_names->Get(context, i).ToLocalChecked();
          ZeekValWrapper::Result index_result = ToZeekVal(key, itypes[0]);

          if (!index_result.ok) {
            wrap_result.ok = false;
            wrap_result.error = index_result.error;
            return wrap_result;
          }

          ZeekValWrapper::Result value_result =
              ToZeekVal(v8_obj->Get(context, key).ToLocalChecked(), yield_type);

          if (!value_result.ok) {
            wrap_result.ok = false;
            wrap_result.error = value_result.error;
            return wrap_result;
          }
          table_val->Assign(index_result.val, value_result.val);
        }
        wrap_result.val = std::move(table_val);
        return wrap_result;
      }
    }
  } else if (type_tag == zeek::TYPE_RECORD) {
    // Take the record type and attempt to assign all non-optional
    // fields from the provided Javascript object.

    if (!v8_val->IsObject()) {
      wrap_result.error = "Expected Javascript object for record of type ";
      wrap_result.error += type->GetName();
    } else {
      zeek::RecordType* rt = type->AsRecordType();
      zeek::RecordTypePtr rtp = {zeek::NewRef{}, rt};  // Not sure this needs NewRef
      zeek::RecordValPtr record_val = zeek::make_intrusive<zeek::RecordVal>(rtp);
      v8::Local<v8::Object> v8_obj = v8::Local<v8::Object>::Cast(v8_val);

      for (int i = 0; i < rt->NumFields() && wrap_result.ok; i++) {
        const zeek::TypeDecl* field_decl = rt->FieldDecl(i);

        const bool is_optional =
            field_decl->GetAttr(zeek::detail::ATTR_OPTIONAL) != zeek::detail::Attr::nil;

        dprintf("i=%d field_name=%s optional=%d", i, field_decl->id, is_optional);

        v8::Local<v8::String> key = v8_str_extern(isolate_, rt, field_decl->id);

        // If the v8_obj does not have this field and the field
        // itself isn't optional, bail out.

        v8::Local<v8::Value> v8_field_value =
            v8_obj->Get(context, key).ToLocalChecked();

        if (v8_field_value->IsUndefined()) {
          if (is_optional)
            continue;

          wrap_result.ok = false;
          wrap_result.error = std::string("missing property ") + field_decl->id;
          wrap_result.error += " for record type " + rt->GetName();
          return wrap_result;
        }

        // If the field is null and it's optional, skip it, otherwise
        // report an error.
        if (v8_field_value->IsNull()) {
          if (is_optional)
            continue;

          wrap_result.ok = false;
          wrap_result.error = std::string("property ") + field_decl->id;
          wrap_result.error += " for record type " + rt->GetName() + " cannot be null";
          return wrap_result;
        }

        ZeekValWrapper::Result field_result =
            ToZeekVal(v8_field_value, field_decl->type);
        if (!field_result.ok) {
          wrap_result.ok = false;
          wrap_result.error += "Error for field ";
          wrap_result.error += field_decl->id;
          wrap_result.error += ": " + field_result.error;
          return wrap_result;
        }

        record_val->Assign(i, field_result.val);
      }

      wrap_result.val = std::move(record_val);
      return wrap_result;
    }
  }

  // Could not convert the type. Attempt to provide a meaningful
  // error message, preserving those existing in wrap_result.
  wrap_result.ok = false;
  wrap_result.val = zeek::ValPtr(nullptr);
  v8::String::Utf8Value utf8_value(isolate_, v8_val);
  v8::Local<v8::String> v8_typeof_str = v8_val->TypeOf(isolate_);
  v8::String::Utf8Value utf8_type(isolate_, v8_typeof_str);

  std::string error = "Unable to convert JS value '";
  error += *utf8_value + std::string("' of type ") + *utf8_type +
           std::string(" to Zeek type ");
  error += (type->IsSet() ? "set" : zeek::type_name(type_tag));
  if (!wrap_result.error.empty()) {
    error += " (";
    error += wrap_result.error;
    error += ")";
  }
  wrap_result.error = error;

  return wrap_result;
}

ZEEKJS_V8_INTERCEPTED ZeekValWrapper::ZeekTableGetter(
    v8::Local<v8::Name> property,
    const v8::PropertyCallbackInfo<v8::Value>& info) {
  v8::Isolate* isolate = info.GetIsolate();
  v8::Local<v8::Object> receiver = info.This();
  auto wrap =
      static_cast<ZeekValWrap*>(receiver->GetAlignedPointerFromInternalField(0));
  if (wrap->GetVal()->GetType()->Tag() != zeek::TYPE_TABLE)
    return ZEEKJS_V8_INTERCEPTED_NO;

  auto tval = static_cast<zeek::TableVal*>(wrap->GetVal());

  v8::String::Utf8Value arg(isolate, property);

  if (!*arg) {
    dprintf("%s", "empty arg?");
    return ZEEKJS_V8_INTERCEPTED_NO;
  }

  zeek::TableTypePtr ttype = tval->GetType<zeek::TableType>();
  std::vector<zeek::TypePtr> itypes = ttype->GetIndexTypes();
  dprintf("tval=%p ttype=%p itypes=%lu property=%s", tval, ttype.get(), itypes.size(),
          *arg);

  if (itypes.size() != 1) {
    v8::Local<v8::Value> error = v8::Exception::TypeError(::v8_str(
        isolate,
        zeek::util::fmt("Unexpected number of index types: %lu", itypes.size())));
    isolate->ThrowException(error);
    return ZEEKJS_V8_INTERCEPTED_NO;
  }

  zeek::TypePtr index_type = itypes[0];
  ZeekValWrapper::Result index_result =
      wrap->GetWrapper()->ToZeekVal(property, index_type);
  if (!index_result.ok)
    return ZEEKJS_V8_INTERCEPTED_NO;

  zeek::ValPtr found_val = tval->Find(index_result.val);
  if (!found_val)
    return ZEEKJS_V8_INTERCEPTED_NO;

  dprintf("tval=%p ttype=%p itypes=%lu property=%s FOUND", tval, ttype.get(),
          itypes.size(), *arg);

  info.GetReturnValue().Set(wrap->GetWrapper()->Wrap(found_val));
  return ZEEKJS_V8_INTERCEPTED_YES;
}

ZEEKJS_V8_INTERCEPTED ZeekValWrapper::ZeekTableSetter(
    v8::Local<v8::Name> property,
    v8::Local<v8::Value> v8_val,
#if (NODE_MAJOR_VERSION <= 22)
    const v8::PropertyCallbackInfo<v8::Value>& info) {
#else
    const v8::PropertyCallbackInfo<void>& info) {
#endif
  v8::Isolate* isolate = info.GetIsolate();
  v8::Local<v8::Object> receiver = info.This();
  auto wrap =
      static_cast<ZeekValWrap*>(receiver->GetAlignedPointerFromInternalField(0));
  auto tval = static_cast<zeek::TableVal*>(wrap->GetVal());

  zeek::TableTypePtr ttype = tval->GetType<zeek::TableType>();
  const auto& itypes = ttype->GetIndexTypes();
  v8::String::Utf8Value property_utf8(isolate, property);
  dprintf("tval=%p ttype=%p itypes=%lu property=%s", tval, ttype.get(), itypes.size(),
          *property_utf8);

  if (itypes.size() != 1) {
    v8::Local<v8::Value> error = v8::Exception::TypeError(::v8_str(
        isolate,
        zeek::util::fmt("Unexpected number of index types: %lu", itypes.size())));
    isolate->ThrowException(error);
    return ZEEKJS_V8_INTERCEPTED_NO;
  }

  zeek::TypePtr index_type = itypes[0];
  ZeekValWrapper::Result property_wrap_result =
      wrap->GetWrapper()->ToZeekVal(property, index_type);
  if (!property_wrap_result.ok) {
    v8::Local<v8::Value> error = v8::Exception::TypeError(::v8_str(
        isolate, zeek::util::fmt("Bad index: %s", property_wrap_result.error.c_str())));
    isolate->ThrowException(error);
    return ZEEKJS_V8_INTERCEPTED_NO;
  }

  ZeekValWrapper::Result value_wrap_result =
      wrap->GetWrapper()->ToZeekVal(v8_val, ttype->Yield());
  if (!value_wrap_result.ok) {
    v8::Local<v8::Value> error = v8::Exception::TypeError(::v8_str(
        isolate, zeek::util::fmt("Bad value: %s", value_wrap_result.error.c_str())));
    isolate->ThrowException(error);
    return ZEEKJS_V8_INTERCEPTED_NO;
  }

  // Broker forward is on...
  tval->Assign(property_wrap_result.val, value_wrap_result.val);

  info.GetReturnValue().Set(v8_val);
  return ZEEKJS_V8_INTERCEPTED_YES;
}

// This is slightly insane - when the Enumerator returns a Name that's
// a number, the IndexGetter is called rather than the property getter.
//
// Maybe that's not so insane, but that's why we have the below and
// may convert from Javascript numbers to String keys in Zeek.
ZEEKJS_V8_INTERCEPTED ZeekValWrapper::ZeekTableIndexGetter(
    uint32_t index,
    const v8::PropertyCallbackInfo<v8::Value>& info) {
  v8::Isolate* isolate = info.GetIsolate();
  v8::Local<v8::Object> receiver = info.This();
  auto wrap =
      static_cast<ZeekValWrap*>(receiver->GetAlignedPointerFromInternalField(0));
  auto tval = static_cast<zeek::TableVal*>(wrap->GetVal());

  dprintf("ZeekTableIndexGetter: tval=%p index=%d", tval, index);

  zeek::TableTypePtr ttype = tval->GetType<zeek::TableType>();
  const auto& itypes = ttype->GetIndexTypes();
  if (itypes.size() != 1) {
    v8::Local<v8::Value> error = v8::Exception::TypeError(::v8_str(
        isolate,
        zeek::util::fmt("Unexpected number of index types: %lu", itypes.size())));
    isolate->ThrowException(error);
    return ZEEKJS_V8_INTERCEPTED_NO;
  }

  zeek::TypePtr index_type = itypes[0];
  v8::Local<v8::Value> v8_index = v8::Integer::NewFromUnsigned(isolate, index);

  // Special case: If the underlying Zeek table has TYPE_STRING entries, convert
  // the index to a string as ToZeekVal() won't do that anymore.
  if (index_type->Tag() == zeek::TYPE_STRING)
    v8_index = v8_index->ToString(isolate->GetCurrentContext()).ToLocalChecked();

  ZeekValWrapper::Result index_result =
      wrap->GetWrapper()->ToZeekVal(v8_index, index_type);
  if (!index_result.ok) {
    v8::Local<v8::Value> error = v8::Exception::TypeError(
        ::v8_str(isolate, zeek::util::fmt("unable to convert index %d to %s", index,
                                          zeek::type_name(index_type->Tag()))));
    isolate->ThrowException(error);
    return ZEEKJS_V8_INTERCEPTED_NO;
  }

  zeek::ValPtr val = tval->Find(index_result.val);
  if (!val) {
    eprintf("Failed to lookup value for index=%d", index);
    return ZEEKJS_V8_INTERCEPTED_NO;
  }
  info.GetReturnValue().Set(wrap->GetWrapper()->Wrap(val));
  return ZEEKJS_V8_INTERCEPTED_YES;
}

ZEEKJS_V8_INTERCEPTED ZeekValWrapper::ZeekTableIndexSetter(
    uint32_t index,
    v8::Local<v8::Value> v8_val,
#if (NODE_MAJOR_VERSION <= 22)
    const v8::PropertyCallbackInfo<v8::Value>& info) {
#else
    const v8::PropertyCallbackInfo<void>& info) {
#endif
  v8::Isolate* isolate = info.GetIsolate();
  v8::Local<v8::Object> receiver = info.This();
  auto wrap =
      static_cast<ZeekValWrap*>(receiver->GetAlignedPointerFromInternalField(0));
  auto tval = static_cast<zeek::TableVal*>(wrap->GetVal());

  dprintf("tval=%p index=%d", tval, index);

  zeek::TableTypePtr ttype = tval->GetType<zeek::TableType>();
  const auto& itypes = ttype->GetIndexTypes();
  if (itypes.size() != 1) {
    v8::Local<v8::Value> error = v8::Exception::TypeError(::v8_str(
        isolate,
        zeek::util::fmt("Unexpected number of index types: %lu", itypes.size())));
    isolate->ThrowException(error);
    return ZEEKJS_V8_INTERCEPTED_NO;
  }

  zeek::TypePtr index_type = itypes[0];
  v8::Local<v8::Value> v8_index = v8::Integer::NewFromUnsigned(isolate, index);

  // Special case: If the underlying Zeek table has TYPE_STRING entries, convert
  // the index to a string as ToZeekVal() won't do that anymore. Otherwise assume
  // the Integer an be converted to whatever is in the table (count or int).
  if (index_type->Tag() == zeek::TYPE_STRING)
    v8_index = v8_index->ToString(isolate->GetCurrentContext()).ToLocalChecked();

  ZeekValWrapper::Result index_wrap_result =
      wrap->GetWrapper()->ToZeekVal(v8_index, index_type);
  if (!index_wrap_result.ok) {
    v8::Local<v8::Value> error = v8::Exception::TypeError(
        ::v8_str(isolate, zeek::util::fmt("unable to convert index %d to %s", index,
                                          zeek::type_name(index_type->Tag()))));
    isolate->ThrowException(error);
    return ZEEKJS_V8_INTERCEPTED_NO;
  }

  ZeekValWrapper::Result value_wrap_result =
      wrap->GetWrapper()->ToZeekVal(v8_val, ttype->Yield());
  if (!value_wrap_result.ok) {
    v8::Local<v8::Value> error = v8::Exception::TypeError(::v8_str(
        isolate, zeek::util::fmt("Bad value: %s", value_wrap_result.error.c_str())));
    isolate->ThrowException(error);
    return ZEEKJS_V8_INTERCEPTED_NO;
  }

  // Broker forward is on...
  tval->Assign(index_wrap_result.val, value_wrap_result.val);

  info.GetReturnValue().Set(v8_val);
  return ZEEKJS_V8_INTERCEPTED_YES;
}

void ZeekValWrapper::ZeekTableEnumerator(
    const v8::PropertyCallbackInfo<v8::Array>& info) {
  v8::Isolate* isolate = info.GetIsolate();
  v8::Local<v8::Context> context = isolate->GetCurrentContext();
  v8::Local<v8::Object> receiver = info.This();
  auto wrap =
      static_cast<ZeekValWrap*>(receiver->GetAlignedPointerFromInternalField(0));
  auto tval = static_cast<zeek::TableVal*>(wrap->GetVal());

  // Easy v8::Array constructor takes int, print an error and return.
  // There's a separate constructor that takes a size_t, but would need
  // to populate differently...
  if (tval->Size() > INT_MAX) {
    eprintf("Too many entries in table: %u", tval->Size());
    return;
  }
  auto size = static_cast<int>(tval->Size());

  zeek::TableTypePtr tt = tval->GetType<zeek::TableType>();
  const zeek::TypeListPtr& tl = tt->GetIndices();
  const auto& itypes = tt->GetIndexTypes();

#ifdef DEBUG
  zeek::TypeTag tag = tt->Tag();
  dprintf("tval=%p tag %d/%s set=%d size=%d itypes=%lu", tval, tag,
          zeek::type_name(tag), tt->IsSet(), size, itypes.size());
#endif

  // Let's shortcut here, only support Pure lists with size 1
  // of the base types, anything else is a bit nuts.
  if (!tl->IsPure()) {
    isolate->ThrowException(::v8_str(isolate, "can enumerate only pure tables"));
    return;
  }

  if (itypes.size() != 1) {
    isolate->ThrowException(::v8_str(isolate, "composite table indices not supported"));
    return;
  }

  if (!zeek::is_atomic_type(itypes[0])) {
    isolate->ThrowException(
        ::v8_str(isolate, "table with non-atomic index not supported"));
    return;
  }

  zeek::ListValPtr lv = tval->ToListVal();
  v8::Local<v8::Array> array = v8::Array::New(isolate, size);
  for (int i = 0; i < size; i++) {
    // zeek::TypeTag tag = lv->Idx(i)->GetType()->Tag();
    // dprintf("tag idx=%lu %d/%s set=%d size=%lu", i, tag,
    // zeek::type_name(tag), tval->GetType()->IsSet(), size);
    v8::Local<v8::Value> v8_val = wrap->GetWrapper()->Wrap(lv->Idx(i));
    v8::Local<v8::String> v8_str = v8_val->ToString(context).ToLocalChecked();
    v8::Local<v8::Name> v8_name = v8::Local<v8::Name>::New(isolate, v8_str);
    array->Set(context, i, v8_name).Check();
  }

  info.GetReturnValue().Set(array);
}

// Callback for looking up properties of a record.
ZEEKJS_V8_INTERCEPTED ZeekValWrapper::ZeekRecordGetter(
    v8::Local<v8::Name> property,
    const v8::PropertyCallbackInfo<v8::Value>& info) {
  v8::Local<v8::Object> receiver = info.This();
  auto wrap =
      static_cast<ZeekValWrap*>(receiver->GetAlignedPointerFromInternalField(0));

#ifdef DEBUG
  v8::Isolate* isolate = info.GetIsolate();
  v8::String::Utf8Value property_utf8(isolate, property);
  dprintf("%s", *property_utf8);
#endif

  if (wrap->GetVal()->GetType()->Tag() != zeek::TYPE_RECORD)
    return ZEEKJS_V8_INTERCEPTED_NO;

  auto rval = wrap->GetVal()->AsRecordVal();
  const auto& rt = rval->GetType<zeek::RecordType>();

  auto offset = wrap->GetWrapper()->GetRecordFieldOffset(rt, property);
  if (offset < 0)
    return ZEEKJS_V8_INTERCEPTED_NO;

  zeek::ValPtr vp = rval->GetFieldOrDefault(offset);
  info.GetReturnValue().Set(wrap->GetWrapper()->Wrap(vp, wrap->GetAttrMask()));

  return ZEEKJS_V8_INTERCEPTED_YES;
}

// Callback for for setting properties on a record.
ZEEKJS_V8_INTERCEPTED ZeekValWrapper::ZeekRecordSetter(
    v8::Local<v8::Name> property,
    v8::Local<v8::Value> v8_val,
#if (NODE_MAJOR_VERSION <= 22)
    const v8::PropertyCallbackInfo<v8::Value>& info) {
#else
    const v8::PropertyCallbackInfo<void>& info) {
#endif
  v8::Isolate* isolate = info.GetIsolate();
  v8::Local<v8::Object> receiver = info.This();
  auto wrap =
      static_cast<ZeekValWrap*>(receiver->GetAlignedPointerFromInternalField(0));
  auto rval = static_cast<zeek::RecordVal*>(wrap->GetVal());
  const auto& rt = rval->GetType<zeek::RecordType>();

  auto offset = wrap->GetWrapper()->GetRecordFieldOffset(rt, property);
  if (offset < 0) {
    v8::String::Utf8Value arg(isolate, property);
    v8::Local<v8::Value> error = v8::Exception::TypeError(
        ::v8_str(isolate, zeek::util::fmt("field %s does not exist in record type %s",
                                          *arg, rt->GetName().c_str())));
    isolate->ThrowException(error);
    return ZEEKJS_V8_INTERCEPTED_NO;
  }

  zeek::TypePtr field_type = rt->GetFieldType(offset);

#ifdef DEBUG
  v8::Local<v8::String> typeof_str = v8_val->TypeOf(isolate);
  v8::String::Utf8Value typeof_utf8(isolate, typeof_str);
  v8::String::Utf8Value val_utf8(isolate, v8_val);
  v8::String::Utf8Value arg(isolate, property);
  dprintf("In setter for %s (%s) %s (%s)", *arg, zeek::type_name(field_type->Tag()),
          *val_utf8, *typeof_utf8);
#endif

  Result wrap_result = wrap->GetWrapper()->ToZeekVal(v8_val, field_type);
  if (!wrap_result.ok) {
    v8::Local<v8::Value> error =
        v8::Exception::TypeError(::v8_str(isolate, wrap_result.error.c_str()));
    isolate->ThrowException(error);
    return ZEEKJS_V8_INTERCEPTED_NO;
  }

  rval->Assign(offset, wrap_result.val);
  info.GetReturnValue().Set(v8_val);
  return ZEEKJS_V8_INTERCEPTED_YES;
}

// Callback for enumerating the properties of a record.
void ZeekValWrapper::ZeekRecordEnumerator(
    const v8::PropertyCallbackInfo<v8::Array>& info) {
  v8::Local<v8::Object> receiver = info.This();
  auto wrap =
      static_cast<ZeekValWrap*>(receiver->GetAlignedPointerFromInternalField(0));

  const auto* val = wrap->GetVal();
  if (val->GetType()->Tag() != zeek::TYPE_RECORD) {
    info.GetReturnValue().Set(v8::Array::New(info.GetIsolate()));
    return;
  }

  const auto& rt = val->GetType<zeek::RecordType>();
  int attr_mask = wrap->GetAttrMask();

  info.GetReturnValue().Set(wrap->GetWrapper()->GetRecordFieldNames(rt, attr_mask));
}

// Implement Query for Zeek records.
ZEEKJS_V8_INTERCEPTED ZeekValWrapper::ZeekRecordQuery(
    v8::Local<v8::Name> property,
    const v8::PropertyCallbackInfo<v8::Integer>& info) {
  v8::Local<v8::Object> receiver = info.This();
  auto wrap =
      static_cast<ZeekValWrap*>(receiver->GetAlignedPointerFromInternalField(0));

#ifdef DEBUG
  v8::Isolate* isolate = info.GetIsolate();
  v8::String::Utf8Value property_utf8(isolate, property);
  dprintf("%s", *property_utf8);
#endif

  const auto* val = wrap->GetVal();
  if (val->GetType()->Tag() != zeek::TYPE_RECORD)
    return ZEEKJS_V8_INTERCEPTED_NO;

  const auto& rt = val->GetType<zeek::RecordType>();
  auto offset = wrap->GetWrapper()->GetRecordFieldOffset(rt, property);
  if (offset < 0)
    return ZEEKJS_V8_INTERCEPTED_NO;

  info.GetReturnValue().Set(v8::PropertyAttribute::ReadOnly |
                            v8::PropertyAttribute::DontDelete);

  return ZEEKJS_V8_INTERCEPTED_YES;
}

v8::Local<v8::String> ZeekValWrapper::v8_str_intern(const char* s) {
  return ::v8_str_intern(isolate_, s);
}
v8::Local<v8::String> ZeekValWrapper::v8_str(const char* s) {
  return ::v8_str(isolate_, s);
}

ZeekValWrap* ZeekValWrap::Make(v8::Isolate* isolate,
                               ZeekValWrapper* wrapper,
                               v8::Local<v8::Object> record_obj,
                               zeek::Val* vp,
                               int attr_mask) {
  return new ZeekValWrap(isolate, wrapper, record_obj, vp, attr_mask);
}

ZeekValWrap::ZeekValWrap(v8::Isolate* isolate,
                         ZeekValWrapper* wrapper,
                         v8::Local<v8::Object> record_obj,
                         zeek::Val* vp,
                         int attr_mask)
    : wrapper_(wrapper), vp_(vp), attr_mask_(attr_mask) {
  record_obj->SetAlignedPointerInInternalField(0, this);
  persistent_obj_.Reset(isolate, record_obj);
  persistent_obj_.SetWeak(this, ZeekValWrap_WeakCallback,
                          v8::WeakCallbackType::kParameter);

  ZeekValWrapKey k{vp_, attr_mask};
  ::wrapped_objects.insert({k, this});

  constexpr int adjust = 8 * sizeof(zeek::RecordVal);
  isolate->AdjustAmountOfExternalAllocatedMemory(adjust);
}

void ZeekValWrap::ZeekValWrap_WeakCallback(
    const v8::WeakCallbackInfo<ZeekValWrap>& data) {
  void* p = data.GetParameter();
  auto wrap = static_cast<ZeekValWrap*>(p);

#ifdef DEBUG
  zeek::TypeTag type_tag = wrap->vp_->GetType()->Tag();
  const std::string& type_name = wrap->vp_->GetType()->GetName();
  dprintf("Unrefing vp_=%p (type tag %d/%s/%s) and deleting wrap=%p", wrap->vp_,
          type_tag, zeek::type_name(type_tag), type_name.c_str(), wrap);
#endif

  ZeekValWrapKey k{wrap->vp_, wrap->attr_mask_};
  ::wrapped_objects.erase(k);

  constexpr int adjust = -8 * static_cast<int>(sizeof(zeek::RecordVal));
  data.GetIsolate()->AdjustAmountOfExternalAllocatedMemory(adjust);

  if (wrap->vp_)
    zeek::Unref(wrap->vp_);

  wrap->persistent_obj_.Reset();

  delete wrap;
}

namespace {

// Collect all types
class TypeCollector : public zeek::detail::TraversalCallback {
 public:
  zeek::detail::TraversalCode PreID(const zeek::detail::ID* id) override {
    if (id->GetType())
      id->GetType()->Traverse(this);
    return zeek::detail::TC_CONTINUE;
  }

  zeek::detail::TraversalCode PreType(const zeek::Type* type) override {
    if (seen.count(type) > 0)
      return zeek::detail::TC_ABORTSTMT;
    seen.insert(type);

    // We don't need to track funcs.
    if (type->Tag() == zeek::TYPE_FUNC)
      return zeek::detail::TC_CONTINUE;

    zeek::TypePtr t =
        zeek::IntrusivePtr<zeek::Type>(zeek::NewRef{}, const_cast<zeek::Type*>(type));

    odesc.Clear();
    t->Describe(&odesc);
    std::string key = odesc.Description();

    if (type_map.count(key) == 0) {
      type_map.insert({key, t});
    }

    return zeek::detail::TC_CONTINUE;
  };

  zeek::ODesc odesc;
  std::map<std::string, zeek::TypePtr> type_map;
  std::set<const zeek::Type*> seen;
};

}  // namespace

ZeekTypeRegistry::ZeekTypeRegistry() {
  TypeCollector type_collector;
  zeek::detail::traverse_all(&type_collector);
  type_map = std::move(type_collector.type_map);
}

zeek::TypePtr ZeekTypeRegistry::Lookup(const std::string& name) {
  return type_map[name];
}
