2021-07-10  Gilles Caulier <caulier.gilles@gmail.com>

	* NEWS: prepare for 7.3.0 release

2021-07-10  Gilles Caulier <caulier.gilles@gmail.com>

	* core/utilities/geolocation/geoiface/tiles/itemmarkertiler.cpp: 
	clazy++ : disable copy constructor and operator to prevent potential
	slicing with this copyable polymorphic class.

2021-07-10  Gilles Caulier <caulier.gilles@gmail.com>

	* project/reports/clazy.sh: disable these checkers

2021-07-10  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/dialogs/dconfigdlgmngr.cpp: clazy must skip this file
	for the moment.

2021-07-10  Gilles Caulier <caulier.gilles@gmail.com>

	* core/utilities/imageeditor/core/iofilesettings.h,
	core/utilities/imageeditor/core/undomanager.cpp: clang++

2021-07-09  Luigi Toscano <luigi.toscano@tiscali.it>

	*
	core/dplugins/generic/metadata/geolocationedit/geolocationeditplugi
	n.cpp, core/libs/album/manager/albummanager_database.cpp,
	core/libs/database/server/databaseserver.cpp: Fix syntax in a few
	user visible and i18n-ed messages  Also remove the final exclamation
	mark from a few error messages, as it should not be used according
	the HIG: https://develop.kde.org/hig/style/writing/wording/

2021-07-09  Luigi Toscano <luigi.toscano@tiscali.it>

	* core/dplugins/dimg/heif/dimgheifplugin.cpp,
	core/dplugins/dimg/imagemagick/dimgimagemagickplugin.cpp,
	core/dplugins/dimg/jpeg/dimgjpegplugin.cpp,
	core/dplugins/dimg/jpeg2000/dimgjpeg2000plugin.cpp,
	core/dplugins/dimg/pgf/dimgpgfplugin.cpp,
	core/dplugins/dimg/png/dimgpngplugin.cpp,
	core/dplugins/dimg/qimage/dimgqimageplugin.cpp,
	core/dplugins/dimg/raw/dimgrawplugin.cpp,
	core/dplugins/dimg/tiff/dimgtiffplugin.cpp,
	core/dplugins/generic/import/dscanner/dscannerplugin.cpp,
	core/dplugins/generic/metadata/geolocationedit/geolocationeditplugi
	n.cpp,
	core/dplugins/generic/metadata/metadataedit/metadataeditplugin.cpp,
	core/dplugins/generic/metadata/timeadjust/timeadjustplugin.cpp,
	core/dplugins/generic/tools/calendar/calendarplugin.cpp,
	core/dplugins/generic/tools/expoblending/expoblendingplugin.cpp,
	core/dplugins/generic/tools/htmlgallery/htmlgalleryplugin.cpp,
	core/dplugins/generic/tools/jalbum/jalbumplugin.cpp,
	core/dplugins/generic/tools/mediaserver/mediaserverplugin.cpp,
	core/dplugins/generic/tools/panorama/panoramaplugin.cpp,
	core/dplugins/generic/tools/printcreator/printcreatorplugin.cpp,
	core/dplugins/generic/tools/sendbymail/sendbymailplugin.cpp,
	core/dplugins/generic/tools/videoslideshow/videoslideshowplugin.cpp
	, core/dplugins/generic/webservices/box/boxplugin.cpp,
	core/dplugins/generic/webservices/dropbox/dbplugin.cpp,
	core/dplugins/generic/webservices/facebook/fbplugin.cpp,
	core/dplugins/generic/webservices/filecopy/fcplugin.cpp,
	core/dplugins/generic/webservices/filetransfer/ftplugin.cpp,
	core/dplugins/generic/webservices/flickr/flickrplugin.cpp,
	core/dplugins/generic/webservices/google/gsplugin.cpp,
	core/dplugins/generic/webservices/imageshack/imageshackplugin.cpp,
	core/dplugins/generic/webservices/imgur/imgurplugin.cpp,
	core/dplugins/generic/webservices/ipfs/ipfsplugin.cpp,
	core/dplugins/generic/webservices/mediawiki/mediawikiplugin.cpp,
	core/dplugins/generic/webservices/onedrive/odplugin.cpp,
	core/dplugins/generic/webservices/pinterest/pplugin.cpp,
	core/dplugins/generic/webservices/piwigo/piwigoplugin.cpp,
	core/dplugins/generic/webservices/rajce/rajceplugin.cpp,
	core/dplugins/generic/webservices/smugmug/smugplugin.cpp,
	core/dplugins/generic/webservices/twitter/twitterplugin.cpp,
	core/dplugins/generic/webservices/unified/unifiedplugin.cpp,
	core/dplugins/generic/webservices/vkontakte/vkplugin.cpp,
	core/dplugins/generic/webservices/yandexfotki/yfplugin.cpp: Fix
	i18n: correct syntax of allow  'allow to' alone does not work, it
	requires an object. See for example:

	https://ell.stackexchange.com/questions/11193/allow-to-infinitive-substantive-verb-ing

2021-07-09  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/fileactionmanager/fileactionmngr.cpp,
	core/libs/properties/captions/disjointmetadata.h,
	core/libs/properties/captions/itemdescedittab.cpp: Disable copy
	constructor and operator to prevent potential slicing with this
	class, reported by Clazy static analyzer.

	https://github.com/KDE/clazy/blob/master/docs/checks/README-copyable-polymorphic.md Instead, use DisjointMetadataDataFields container setter and getter. TODO: remove legacy implementations for these methods later if no side effect.

2021-07-09  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/properties/captions/disjointmetadata.cpp,
	core/libs/properties/captions/disjointmetadata.h,
	core/libs/properties/captions/disjointmetadata_p.cpp,
	core/libs/properties/captions/disjointmetadata_p.h: 
	DisjointMetadata: add setter and getter for
	DisjointMetadataDataFields constainer

2021-07-09  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/fileactionmanager/databaseworkeriface.cpp,
	core/libs/fileactionmanager/databaseworkeriface.h,
	core/libs/fileactionmanager/fileactionmngr.cpp,
	core/libs/fileactionmanager/fileactionmngr.h,
	core/libs/fileactionmanager/fileactionmngr_p.cpp: fix broken
	signal/slot

2021-07-09  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/fileactionmanager/databaseworkeriface.cpp,
	core/libs/properties/captions/disjointmetadata.cpp,
	core/libs/properties/captions/disjointmetadata.h,
	core/libs/properties/captions/disjointmetadata_p.h,
	core/libs/properties/captions/disjointmetadatadatafields.h,
	core/libs/properties/captions/itemdescedittab.cpp,
	core/libs/properties/captions/itemdescedittab.h: move
	DisjointMetadata::Status enum to DisjointMetataDataFields container


2021-07-09  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/properties/CMakeLists.txt,
	core/libs/properties/captions/disjointmetadata.cpp,
	core/libs/properties/captions/disjointmetadata_p.cpp,
	core/libs/properties/captions/disjointmetadata_p.h,
	core/libs/properties/captions/disjointmetadatadatafields.h: Separate
	DisjointMetadata private and data fields containers

2021-07-09  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/fileactionmanager/databaseworkeriface.cpp,
	core/libs/fileactionmanager/databaseworkeriface.h,
	core/libs/fileactionmanager/fileactionmngr.cpp,
	core/libs/fileactionmanager/fileactionmngr.h: constify

2021-07-08  Maik Qualmann <metzpinguin@gmail.com>

	* NEWS: update

2021-07-08  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/properties/captions/disjointmetadata.cpp,
	core/libs/properties/captions/disjointmetadata.h: fix coding style

2021-07-08  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/dialogs/dconfigdlgmngr.cpp,
	core/libs/dialogs/dconfigdlgmngr.h: fix coding style

2021-07-08  l10n daemon script <scripty@kde.org>

	* core/app/main/digikam.notifyrc,
	core/dplugins/generic/tools/htmlgallery/themes/dateframes/dateframe
	s.desktop,
	core/dplugins/generic/tools/htmlgallery/themes/html5responsive/html
	5responsive.desktop: SVN_SILENT made messages (.desktop file) -
	always resolve ours  In case of conflict in i18n, keep the version
	of the branch "ours" To resolve a particular conflict, "git checkout
	--ours path/to/file.desktop"

2021-07-07  Maik Qualmann <metzpinguin@gmail.com>

	* core/libs/metadataengine/dmetadata/dmetadata_faces.cpp: polish

2021-07-07  Maik Qualmann <metzpinguin@gmail.com>

	* core/libs/metadataengine/dmetadata/dmetadata_tags.cpp,
	core/tests/metadataengine/tagsreadwrite_utest.cpp: remove copy
	QStringList

2021-07-07  Maik Qualmann <metzpinguin@gmail.com>

	* NEWS, core/libs/metadataengine/dmetadata/dmetadata_faces.cpp,
	core/libs/metadataengine/dmetadata/dmetadata_tags.cpp: replace slash
	in tags/people names with a backslash BUGS: 439523 FIXED-IN: 7.3.0

2021-07-07  Gilles Caulier <caulier.gilles@gmail.com>

	* core/dplugins/generic/tools/dngconverter/dngconverterdialog.cpp,
	core/dplugins/generic/tools/dngconverter/dngconvertertask.cpp,
	core/dplugins/generic/tools/dngconverter/dngconvertertask.h,
	core/dplugins/generic/tools/dngconverter/dngconverterthread.cpp: 
	clazy++

2021-07-07  Gilles Caulier <caulier.gilles@gmail.com>

	* core/utilities/imageeditor/core/undomanager.cpp: clang++

2021-07-07  Gilles Caulier <caulier.gilles@gmail.com>

	* core/dplugins/generic/webservices/imageshack/imageshacktalker.cpp: 
	krazy++

2021-07-07  Gilles Caulier <caulier.gilles@gmail.com>

	* core/dplugins/generic/webservices/inaturalist/inattalker.cpp: 
	clazy++ : fix internal copyable polymorphic classes which can expose
	to potential slicing

2021-07-07  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/properties/captions/disjointmetadata.cpp,
	core/libs/properties/captions/disjointmetadata.h: fix coding style

2021-07-06  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/metadataengine/engine/metaengine.h,
	core/libs/threadimageio/fileio/loadingcache.cpp,
	core/utilities/import/backend/cameracontroller.cpp,
	core/utilities/import/backend/cameracontroller.h,
	core/utilities/import/main/importui.cpp,
	core/utilities/import/main/importui.h: Disable copy constructor and
	operator to prevent potential slicing with this class, reported by
	Clazy static analyzer.

	https://github.com/KDE/clazy/blob/master/docs/checks/README-copyable-polymorphic.md This commit fix more than 800 Clazy reports with metaengine.h header in whole digiKam source code. This methods was implemented to be able to pass this class or a derived version to signals and slots (only used between CameraController and ImportUI classes). This is very dangerous as virtual methods are present in this polymorphic class and is copyable. Instead to use this class in signals and slots, use MetaEngineData container. TODO: remove legacy implementations for these methods later if no side effect.

2021-07-06  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/dialogs/dconfigdlgmngr.cpp: clazy++

2021-07-06  Gilles Caulier <caulier.gilles@gmail.com>

	* project/reports/cppcheck.sh: add ":*" with this cppcheck option to
	remove unwanted reports details :

	https://stackoverflow.com/questions/41064612/cppcheck-how-to-suppress-inline-unmatched-suppression

2021-07-06  Gilles Caulier <caulier.gilles@gmail.com>

	* NEWS: update

2021-07-06  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/tags/widgets/addtagscombobox.cpp,
	core/libs/tags/widgets/addtagscombobox.h,
	core/libs/tags/widgets/addtagslineedit.cpp,
	core/libs/tags/widgets/addtagslineedit.h: clazy++ : pass context
	obaject as 3rd arg

2021-07-06  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/widgets/text/searchtextbar.cpp: clazy++ : pass context
	obaject as 3ed arg

2021-07-06  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/metadataengine/exiftool/exiftoolprocess_p.cpp,
	core/libs/metadataengine/exiftool/exiftoolprocess_p.h: clazy++: use
	Q_EMIT macro here

2021-07-05  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/widgets/metadata/exiftool/exiftoollistview.cpp: remove
	empty Exiftool group in list if custom filtering is active

2021-07-04  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/widgets/metadata/exiftool/exiftoollistview.cpp: 
	cppcheck++

2021-07-04  Maik Qualmann <metzpinguin@gmail.com>

	* core/libs/database/haar/haariface.cpp: polish

2021-07-04  Maik Qualmann <metzpinguin@gmail.com>

	* core/utilities/fuzzysearch/findduplicatesview.cpp: fix missing
	slot

2021-07-04  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/widgets/iccprofiles/iccprofilewidget.cpp,
	core/libs/widgets/iccprofiles/iccprofilewidget.h,
	core/libs/widgets/metadata/exiftool/exiftoollistview.cpp,
	core/libs/widgets/metadata/exiftool/exiftoollistview.h,
	core/libs/widgets/metadata/exiftool/exiftoolwidget.cpp,
	core/libs/widgets/metadata/exiv2/exifwidget.cpp,
	core/libs/widgets/metadata/exiv2/iptcwidget.cpp,
	core/libs/widgets/metadata/exiv2/makernotewidget.cpp,
	core/libs/widgets/metadata/exiv2/xmpwidget.cpp: polish

2021-07-04  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/widgets/metadata/exiv2/exifwidget.cpp: typo

2021-07-04  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/widgets/metadata/exiftool/exiftoollistview.cpp,
	core/libs/widgets/metadata/exiftool/exiftoolwidget.cpp: Always
	handle filter settings at load metadata from ExifTool

2021-07-03  Maik Qualmann <metzpinguin@gmail.com>

	* core/utilities/import/backend/gpcamera.cpp,
	core/utilities/import/backend/umscamera.cpp: polish

2021-07-03  Maik Qualmann <metzpinguin@gmail.com>

	* NEWS, core/utilities/import/backend/gpcamera.cpp,
	core/utilities/import/backend/umscamera.cpp,
	core/utilities/import/dialogs/camerainfodialog.cpp: use plain text
	for camera informations BUGS: 439443 FIXED-IN: 7.3.0

2021-07-03  Maik Qualmann <metzpinguin@gmail.com>

	* NEWS, core/libs/video/player/mediaplayerview.cpp: fix crash in the
	video-slideshow media player BUGS: 439436 FIXED-IN: 7.3.0

2021-07-03  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/properties/itempropertiesmetadatatab.cpp,
	core/libs/widgets/metadata/exiftool/exiftoollistview.cpp,
	core/libs/widgets/metadata/exiftool/exiftoollistview.h,
	core/libs/widgets/metadata/exiftool/exiftoollistviewitem.cpp,
	core/libs/widgets/metadata/exiftool/exiftoollistviewitem.h,
	core/libs/widgets/metadata/exiftool/exiftoolwidget.cpp,
	core/libs/widgets/metadata/exiftool/exiftoolwidget.h,
	core/libs/widgets/metadata/exiv2/metadatalistview.h: ExifTool
	metadata viewer : Start to handle tag filters as Exiv2 filters.
	There is a bug with Photograh filter mode (Exiv2 and Exiftool).
	There is no difference with no filter mode. This needs
	investiguations before 7.3.0 release

2021-07-03  Maik Qualmann <metzpinguin@gmail.com>

	* NEWS, core/libs/properties/captions/disjointmetadata.cpp: fix
	writing face tags when tags are not activated BUGS: 439404 FIXED-IN:
	7.3.0

2021-07-03  l10n daemon script <scripty@kde.org>

	*
	core/dplugins/generic/tools/htmlgallery/themes/dateframes/dateframe
	s.desktop: SVN_SILENT made messages (.desktop file) - always resolve
	ours  In case of conflict in i18n, keep the version of the branch
	"ours" To resolve a particular conflict, "git checkout --ours
	path/to/file.desktop"

2021-07-03  l10n daemon script <scripty@kde.org>

	* core/showfoto/main/org.kde.showfoto.appdata.xml: GIT_SILENT made
	messages (after extraction)

2021-07-02  Maik Qualmann <metzpinguin@gmail.com>

	* NEWS, core/libs/transitionmngr/frameutils.cpp: auto rotate images
	in the video slideshow creator BUGS: 439409 FIXED-IN: 7.3.0

2021-06-29  Maik Qualmann <metzpinguin@gmail.com>

	* NEWS: update

2021-06-28  Maik Qualmann <metzpinguin@gmail.com>

	* core/libs/metadataengine/exiftool/exiftoolprocess.cpp: define
	ExifTool common arguments The argument "-@ -" must be defined for
	the -common_args ". CCBUGS: 439231

2021-06-28  Gilles Caulier <caulier.gilles@gmail.com>

	* project/bundles/mxe/04-build-installer.sh: Bump to ExifTool 12.28
	for Windows CCBUGS: 439231

2021-06-27  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/metadataengine/exiftool/exiftoolparser.cpp,
	core/libs/metadataengine/exiftool/exiftoolparser.h,
	core/libs/widgets/metadata/config/metadatapanel.cpp,
	core/libs/widgets/metadata/config/metadatapanel.h,
	core/libs/widgets/metadata/config/metadataselector.cpp,
	core/libs/widgets/metadata/config/metadataselector.h,
	core/libs/widgets/metadata/exiftool/exiftoollistview.cpp: Add new
	settings panel to configure prefered and customized list of ExifTool
	tags to display in Metadata viewer. TODO: implement ExifTool tags
	filter.

2021-06-27  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/widgets/metadata/config/metadataselector.cpp,
	core/libs/widgets/metadata/config/metadataselector.h: polish

2021-06-27  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/metadataengine/exiftool/exiftoolparser.cpp,
	core/libs/metadataengine/exiftool/exiftoolparser.h: this method can
	be static

2021-06-27  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/metadataengine/exiftool/exiftoolparser.cpp,
	core/libs/metadataengine/exiftool/exiftoolparser.h,
	core/tests/metadataengine/exiftool/exiftooltagsdb_cli.cpp: new
	public method to convert unordered hash table of ExifToolData to an
	ordered MetadEngine map

2021-06-27  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/metadataengine/exiftool/exiftoolparser.h,
	core/libs/widgets/metadata/config/metadatapanel.cpp,
	core/libs/widgets/metadata/config/metadatapanel.h,
	core/libs/widgets/metadata/config/metadataselector.cpp,
	core/libs/widgets/metadata/config/metadataselector.h: polish

2021-06-26  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/metadataengine/exiftool/exiftoolparser_command.cpp: 
	Interpret tag contents

2021-06-26  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/metadataengine/CMakeLists.txt,
	core/libs/metadataengine/exiftool/exiftoolparser.h,
	core/libs/metadataengine/exiftool/exiftoolparser_command.cpp,
	core/libs/metadataengine/exiftool/exiftoolparser_output.cpp,
	core/libs/metadataengine/exiftool/exiftoolparser_p.cpp,
	core/libs/metadataengine/exiftool/exiftoolparser_p.h,
	core/libs/metadataengine/exiftool/exiftoolprocess.h,
	core/tests/metadataengine/exiftool/CMakeLists.txt,
	core/tests/metadataengine/exiftool/exiftooltagsdb_cli.cpp: Exiftool:
	add new method to extract whole tags database properties (XML
	version). The hash table returned include the full tag name
	(group0/1/2 + id) as key and description, type, and writable
	properties. The goal of this method is to add an Exiftool settings
	panel to customize tags list to display in metadata viewer, as it's
	already do with Exiv2.

2021-06-26  Maik Qualmann <metzpinguin@gmail.com>

	* core/libs/metadataengine/dmetadata/dmetadata_fileio.cpp: add
	special case to load the metadata with the FFmpeg parser The mime
	type "INSV" is unknown to QMimeDatabase. CCBUGS: 439161

2021-06-25  Maik Qualmann <metzpinguin@gmail.com>

	* NEWS: update

2021-06-25  Maik Qualmann <metzpinguin@gmail.com>

	* core/libs/metadataengine/exiftool/exiftoolparser_command.cpp,
	core/libs/metadataengine/exiftool/exiftoolparser_p.cpp,
	core/libs/metadataengine/exiftool/exiftoolparser_p.h: use command
	action to identify async loading

2021-06-25  Gilles Caulier <caulier.gilles@gmail.com>

	* core/app/items/overlays/assignnameoverlay.cpp,
	core/app/items/overlays/facerejectionoverlay.cpp,
	core/app/items/overlays/itemratingoverlay.cpp,
	core/app/items/overlays/itemselectionoverlay.cpp: anti spam

2021-06-25  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/pgfutils/pgfutils.cpp, core/libs/pgfutils/pgfutils.h: 
	polish

2021-06-25  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/pgfutils/libpgf/WaveletTransform.h: fix compiler
	warnings

2021-06-25  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/pgfutils/libpgf/Subband.cpp: fixx compiler warnings

2021-06-25  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/pgfutils/libpgf/PGFstream.cpp: restore asan fix reverted
	with last libpgf update

2021-06-24  Gilles Caulier <caulier.gilles@gmail.com>

	* NEWS, core/libs/pgfutils/libpgf/Decoder.cpp,
	core/libs/pgfutils/libpgf/Decoder.h,
	core/libs/pgfutils/libpgf/Encoder.cpp,
	core/libs/pgfutils/libpgf/Encoder.h,
	core/libs/pgfutils/libpgf/PGFimage.cpp,
	core/libs/pgfutils/libpgf/PGFplatform.h,
	core/libs/pgfutils/libpgf/PGFstream.cpp,
	core/libs/pgfutils/libpgf/PGFtypes.h,
	core/libs/pgfutils/libpgf/README,
	core/libs/pgfutils/libpgf/Subband.cpp,
	core/libs/pgfutils/libpgf/WaveletTransform.cpp: Update internal
	Libpgf to 7.21.7 (18-02-2021)

2021-06-24  Maik Qualmann <metzpinguin@gmail.com>

	* core/libs/widgets/metadata/exiftool/exiftoollistview.cpp,
	core/libs/widgets/metadata/exiftool/exiftoollistview.h,
	core/libs/widgets/metadata/exiftool/exiftoolwidget.cpp,
	core/libs/widgets/metadata/exiftool/exiftoolwidget.h: factoring

2021-06-24  Maik Qualmann <metzpinguin@gmail.com>

	* core/libs/metadataengine/exiftool/exiftoolparser.h,
	core/libs/metadataengine/exiftool/exiftoolparser_command.cpp,
	core/libs/metadataengine/exiftool/exiftoolparser_p.cpp,
	core/libs/metadataengine/exiftool/exiftoolparser_p.h: polish

2021-06-24  Maik Qualmann <metzpinguin@gmail.com>

	* core/libs/widgets/metadata/exiftool/exiftoollistview.cpp,
	core/libs/widgets/metadata/exiftool/exiftoollistview.h,
	core/libs/widgets/metadata/exiftool/exiftoolwidget.cpp: factoring

2021-06-24  Maik Qualmann <metzpinguin@gmail.com>

	* core/libs/metadataengine/exiftool/exiftoolparser_output.cpp,
	core/libs/widgets/metadata/exiftool/exiftoollistview.cpp,
	core/libs/widgets/metadata/exiftool/exiftoollistview.h,
	core/libs/widgets/metadata/exiftool/exiftoolwidget.cpp,
	core/libs/widgets/metadata/exiftool/exiftoolwidget.h: handle
	ExifTool Widget error view correctly in asynchronous mode

2021-06-24  Maik Qualmann <metzpinguin@gmail.com>

	* core/libs/properties/itempropertiesmetadatatab.cpp,
	core/libs/properties/itempropertiesmetadatatab.h,
	core/libs/widgets/metadata/exiv2/metadatawidget.cpp,
	core/libs/widgets/metadata/exiv2/metadatawidget.h: remove
	QtConcurrent here too As we wait for the thread to end there are no
	advantages for the main thread.

2021-06-24  Maik Qualmann <metzpinguin@gmail.com>

	* core/libs/metadataengine/exiftool/exiftoolparser.h,
	core/libs/metadataengine/exiftool/exiftoolparser_command.cpp,
	core/libs/metadataengine/exiftool/exiftoolparser_output.cpp,
	core/libs/metadataengine/exiftool/exiftoolparser_p.cpp,
	core/libs/metadataengine/exiftool/exiftoolparser_p.h,
	core/libs/metadataengine/exiftool/exiftoolprocess.cpp,
	core/libs/metadataengine/exiftool/exiftoolprocess_p.cpp,
	core/libs/metadataengine/exiftool/exiftoolprocess_p.h,
	core/libs/widgets/metadata/exiftool/exiftoollistview.cpp,
	core/libs/widgets/metadata/exiftool/exiftoollistview.h: remove
	QtConcurrent and add asynchronous mode for the exifToolParser

2021-06-24  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/widgets/iccprofiles/iccprofilewidget.cpp,
	core/libs/widgets/iccprofiles/iccprofilewidget.h,
	core/libs/widgets/metadata/exiv2/exifwidget.cpp,
	core/libs/widgets/metadata/exiv2/exifwidget.h,
	core/libs/widgets/metadata/exiv2/iptcwidget.cpp,
	core/libs/widgets/metadata/exiv2/iptcwidget.h,
	core/libs/widgets/metadata/exiv2/makernotewidget.cpp,
	core/libs/widgets/metadata/exiv2/makernotewidget.h,
	core/libs/widgets/metadata/exiv2/metadatawidget.cpp,
	core/libs/widgets/metadata/exiv2/metadatawidget.h,
	core/libs/widgets/metadata/exiv2/xmpwidget.cpp,
	core/libs/widgets/metadata/exiv2/xmpwidget.h: factoring

2021-06-24  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/widgets/metadata/exiftool/exiftoolwidget.cpp: factoring


2021-06-23  Gilles Caulier <caulier.gilles@gmail.com>

	* NEWS: update

2021-06-23  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/widgets/metadata/exiftool/exiftoolwidget.cpp: Fix crash
	in ExifTool metadat aview when helper buttons are used BUGS: 439057
	FIXED-IN: 7.3.0

2021-06-23  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/widgets/metadata/exiv2/metadatawidget.cpp: inversed
	logic

2021-06-23  Gilles Caulier <caulier.gilles@gmail.com>

	* NEWS: update

2021-06-23  Gilles Caulier <caulier.gilles@gmail.com>

	* project/bundles/macports/04-build-installer.sh: Fix path to mv Qt
	translator ressources

2021-06-23  Gilles Caulier <caulier.gilles@gmail.com>

	* project/bundles/macports/04-build-installer.sh: move Qt
	translation files at the right place in MacOS bundle CCBUGS: 438701


2021-06-23  Gilles Caulier <caulier.gilles@gmail.com>

	* core/tests/vkontakte/albums_utest.cpp,
	core/tests/vkontakte/albums_utest.h,
	core/tests/vkontakte/frequentrequests_utest.cpp,
	core/tests/vkontakte/frequentrequests_utest.h,
	core/tests/vkontakte/photos_utest.cpp,
	core/tests/vkontakte/photos_utest.h,
	core/tests/vkontakte/userinfo_utest.cpp,
	core/tests/vkontakte/userinfo_utest.h,
	core/tests/vkontakte/vktestbase.cpp,
	core/tests/vkontakte/vktestbase.h: clazy++

2021-06-23  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/metadataengine/exiftool/exiftoolparser.h,
	core/libs/metadataengine/exiftool/exiftoolparser_command.cpp,
	core/libs/metadataengine/exiftool/exiftoolparser_output.cpp,
	core/libs/metadataengine/exiftool/exiftoolprocess.h,
	core/libs/metadataengine/exiftool/exiftoolprocess_p.h: fix coding
	style

2021-06-22  Gilles Caulier <caulier.gilles@gmail.com>

	* project/reports/cppcheck.sh: disable cppcheck useStlAlgorithm

2021-06-22  Gilles Caulier <caulier.gilles@gmail.com>

	* NEWS: update

2021-06-22  Gilles Caulier <caulier.gilles@gmail.com>

	* NEWS: update

2021-06-22  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/rawengine/libraw/README.DNGSDK.txt,
	core/libs/rawengine/libraw/libraw/libraw_types.h,
	core/libs/rawengine/libraw/src/tables/colorconst.cpp: update
	internal libraw to git/master from 22/06/2021

2021-06-21  Maik Qualmann <metzpinguin@gmail.com>

	* core/utilities/searchwindow/searchfields.cpp: remove unused
	include

2021-06-21  Maik Qualmann <metzpinguin@gmail.com>

	* core/utilities/searchwindow/searchfields.cpp: cleanup includes

2021-06-21  Maik Qualmann <metzpinguin@gmail.com>

	* core/utilities/searchwindow/searchfields.cpp: remove old dead code


2021-06-21  Maik Qualmann <metzpinguin@gmail.com>

	* core/utilities/searchwindow/searchfields.cpp,
	core/utilities/searchwindow/searchfields.h: set valid value state

2021-06-21  Maik Qualmann <metzpinguin@gmail.com>

	* core/libs/album/treeview/albumselectiontreeview.cpp,
	core/libs/tags/widgets/tagfolderview.cpp: change expand/collapse
	icon

2021-06-21  Maik Qualmann <metzpinguin@gmail.com>

	* NEWS, core/libs/album/treeview/abstractalbumtreeview.cpp,
	core/libs/album/treeview/abstractalbumtreeview.h,
	core/libs/album/treeview/abstractalbumtreeview_p.h,
	core/libs/album/treeview/albumselectiontreeview.cpp,
	core/libs/tags/widgets/tagfolderview.cpp,
	core/libs/tags/widgets/tagfolderview.h: add context menu entries to
	expand and collapse album nodes BUGS: 326247 FIXED-IN: 7.3.0

2021-06-21  Maik Qualmann <metzpinguin@gmail.com>

	* NEWS: update

2021-06-21  Maik Qualmann <metzpinguin@gmail.com>

	* NEWS, core/libs/database/item/query/itemquerybuilder.cpp,
	core/utilities/searchwindow/searchfields.cpp,
	core/utilities/searchwindow/searchfields.h: add search for a day
	from the collection BUGS: 438961 FIXED-IN: 7.3.0

2021-06-21  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/widgets/metadata/exiftool/exiftoollistview.cpp,
	core/libs/widgets/metadata/exiv2/exifwidget.cpp,
	core/libs/widgets/metadata/exiv2/iptcwidget.cpp,
	core/libs/widgets/metadata/exiv2/makernotewidget.cpp,
	core/libs/widgets/metadata/exiv2/xmpwidget.cpp: polish

2021-06-21  Maik Qualmann <metzpinguin@gmail.com>

	* NEWS: update

2021-06-21  Maik Qualmann <metzpinguin@gmail.com>

	* core/libs/metadataengine/exiftool/exiftoolparser_p.cpp: ExifTool
	use now UTF-8 file paths under Windows BUGS: 438888 FIXED-IN: 7.3.0


2021-06-20  Gilles Caulier <caulier.gilles@gmail.com>

	* core/utilities/imageeditor/editor/editorwindow.cpp: cppcheck++

2021-06-20  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/widgets/metadata/exiv2/metadatawidget.cpp: cppcheck++

2021-06-20  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/widgets/metadata/exiftool/exiftoolwidget.cpp: cppcheck++


2021-06-20  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/album/manager/albummanager_database.cpp: cppcheck++

2021-06-20  Gilles Caulier <caulier.gilles@gmail.com>

	* core/utilities/import/models/importimagemodel.cpp: cppcheck++

2021-06-20  Gilles Caulier <caulier.gilles@gmail.com>

	* core/showfoto/thumbbar/showfotoimagemodel.cpp: cppcheck++

2021-06-20  Gilles Caulier <caulier.gilles@gmail.com>

	* core/dplugins/generic/webservices/inaturalist/inattaxon.cpp,
	core/dplugins/generic/webservices/inaturalist/inattaxon.h: no need
	to decalre this operator

2021-06-20  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/database/models/itemmodel.cpp,
	core/libs/database/models/itemmodel.h,
	core/showfoto/thumbbar/showfotoimagemodel.cpp,
	core/showfoto/thumbbar/showfotoimagemodel.h,
	core/utilities/import/models/importimagemodel.cpp,
	core/utilities/import/models/importimagemodel.h: cppcheck++

2021-06-20  Gilles Caulier <caulier.gilles@gmail.com>

	* core/app/items/utils/contextmenuhelper.cpp,
	core/app/items/utils/contextmenuhelper.h,
	core/libs/album/treeview/albumselectiontreeview.cpp: Remove dead
	code

2021-06-20  Gilles Caulier <caulier.gilles@gmail.com>

	* core/app/items/utils/contextmenuhelper.cpp: cppcheck++ : there is
	no code to fill this container. Why? Dropped by error? Never
	implemented?

2021-06-20  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/widgets/files/dbinaryiface.cpp: inline comment in
	cppcheck suppression use ; separator

2021-06-20  Maik Qualmann <metzpinguin@gmail.com>

	* core/libs/metadataengine/exiftool/exiftoolparser_p.cpp: try again
	with a file path in UTF-8

2021-06-20  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/widgets/files/dbinaryiface.cpp: cppcheck++

2021-06-20  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/metadataengine/exiftool/exiftoolprocess.cpp: ExifTool :
	use UTF8 with IPTC encoding

2021-06-20  Gilles Caulier <caulier.gilles@gmail.com>

	* core/utilities/geolocation/geoiface/widgets/mapwidget.cpp: 
	cppcheck++

2021-06-20  Gilles Caulier <caulier.gilles@gmail.com>

	* core/utilities/geolocation/geoiface/backends/backendmarble.cpp: 
	cppcheck++

2021-06-20  Gilles Caulier <caulier.gilles@gmail.com>

	*
	core/utilities/geolocation/geoiface/backends/backendgooglemaps.cpp: 
	cppcheck++

2021-06-20  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/album/manager/albummanager_talbum.cpp: use dynamic cast
	to prevent null pointer dereference

2021-06-20  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/album/manager/albummanager_palbum.cpp: use dynamic cast
	to prevent null pointer dereference

2021-06-20  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/tags/engine/tagmodificationhelper.cpp: cppcheck++ :
	dynamic cast already double check for null pointer dereference

2021-06-20  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/album/manager/albummanager_talbum.cpp: cppcheck++: no
	need to double check toBeRemoved validity

2021-06-20  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/album/manager/albummanager_talbum.cpp: cppcheck++ : no
	need to double check album validity

2021-06-20  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/album/manager/albummanager.cpp,
	core/libs/album/manager/albummanager.h,
	core/libs/album/manager/albummanager_album.cpp,
	core/libs/album/manager/albummanager_collection.cpp,
	core/libs/album/manager/albummanager_dalbum.cpp,
	core/libs/album/manager/albummanager_database.cpp,
	core/libs/album/manager/albummanager_falbum.cpp,
	core/libs/album/manager/albummanager_palbum.cpp,
	core/libs/album/manager/albummanager_talbum.cpp: fix coding style

2021-06-20  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/album/manager/albummanager_palbum.cpp: cppcheck++:
	toBeRemoved validity is already check with child loop and while
	condition.

2021-06-19  Maik Qualmann <metzpinguin@gmail.com>

	* NEWS, core/app/main/digikamapp_camera.cpp: change keyboard
	shortcuts to add images, now used by the KXmlGui The new keyboard
	shortcut is now ALT+SHIFT+I BUGS: 438878 FIXED-IN: 7.3.0

2021-06-19  Gilles Caulier <caulier.gilles@gmail.com>

	* core/dplugins/generic/tools/mediaserver/server/dmediaserver.cpp: 
	cppcheck++

2021-06-19  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/tags/engine/tagmodificationhelper.cpp,
	core/libs/tags/engine/tagmodificationhelper.h: cppcheck++

2021-06-19  Gilles Caulier <caulier.gilles@gmail.com>

	* core/tests/dimg/dimghistorygraph_utest.cpp: cppcheck++

2021-06-19  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/properties/itempropertiessidebar.cpp: cppcheck++

2021-06-19  Gilles Caulier <caulier.gilles@gmail.com>

	* core/utilities/imageeditor/core/undomanager.cpp,
	core/utilities/imageeditor/core/undomanager.h: cppcheck++

2021-06-19  Gilles Caulier <caulier.gilles@gmail.com>

	*
	core/utilities/geolocation/geoiface/reversegeocoding/rgtagmodel.cpp: 
	cppcheck++

2021-06-19  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/album/treeview/albumselectiontreeview.cpp: cppcheck++

2021-06-19  Gilles Caulier <caulier.gilles@gmail.com>

	* core/dplugins/dimg/pgf/dimgpgfloader.cpp,
	core/dplugins/dimg/pgf/dimgpgfloader.h: cppcheck++

2021-06-19  Gilles Caulier <caulier.gilles@gmail.com>

	* core/app/dragdrop/tagdragdrop.cpp: cppcheck++ destAlbum check is
	already done previously. Remove checks dependencies.

2021-06-19  Gilles Caulier <caulier.gilles@gmail.com>

	* core/app/dragdrop/albumdragdrop.cpp: cppcheck++ : condition to
	check destAlbum is already done before these instances. They can be
	deleted.

2021-06-19  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/metadataengine/exiftool/exiftoolparser_p.cpp: missing
	version string to handle in this switch case

2021-06-19  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/dplugins/widgets/ditemslist.cpp: cppcheck++ : url list
	is never empty here

2021-06-19  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/tags/engine/tagmodificationhelper.cpp: cppcheck++ : no
	need to double check tag pointer here.

2021-06-19  Gilles Caulier <caulier.gilles@gmail.com>

	* core/utilities/facemanagement/items/facegroup.cpp: cppcheck++

2021-06-19  Maik Qualmann <metzpinguin@gmail.com>

	* core/libs/metadataengine/exiftool/exiftoolprocess.cpp: try with
	the charset command for ExifTool CCBUGS: 438888

2021-06-19  Maik Qualmann <metzpinguin@gmail.com>

	* NEWS,
	core/dplugins/generic/tools/dngconverter/dngconverterlist.cpp: 
	ignore DNG files in the DNG converter tool BUGS: 438856 FIXED-IN:
	7.3.0

2021-06-19  Maik Qualmann <metzpinguin@gmail.com>

	* NEWS,
	core/dplugins/generic/tools/dngconverter/dngconverterdialog.cpp,
	core/dplugins/generic/tools/dngconverter/dngconvertertask.cpp: fix
	DNG-Converter progressbar and thread finished BUGS: 438855 FIXED-IN:
	7.3.0

2021-06-19  Gilles Caulier <caulier.gilles@gmail.com>

	* core/utilities/searchwindow/searchmodificationhelper.cpp,
	core/utilities/searchwindow/searchmodificationhelper.h: cppcheck++

2021-06-19  Gilles Caulier <caulier.gilles@gmail.com>

	* core/utilities/imageeditor/core/editorcore.cpp,
	core/utilities/imageeditor/core/editorcore.h: cppcheck++

2021-06-19  Gilles Caulier <caulier.gilles@gmail.com>

	*
	core/utilities/geolocation/geoiface/reversegeocoding/rgtagmodel.cpp
	, core/utilities/geolocation/geoiface/reversegeocoding/rgtagmodel.h: 
	cppcheck++

2021-06-19  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/tags/engine/taggingaction.cpp,
	core/libs/tags/engine/tagmodificationhelper.cpp,
	core/libs/tags/engine/tagmodificationhelper.h,
	core/libs/tags/engine/tagsactionmngr.cpp,
	core/libs/tags/engine/tagscompleter.h: cppcheck++

2021-06-19  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/fileactionmanager/metadatahub.cpp,
	core/libs/fileactionmanager/metadatahub.h: cppcheck++

2021-06-19  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/database/item/containers/itemcomments.cpp,
	core/libs/database/item/containers/itemcomments.h,
	core/libs/database/item/containers/itemcopyright.h,
	core/libs/database/item/containers/iteminfo.h,
	core/libs/database/item/containers/itemposition.cpp,
	core/libs/database/item/containers/itemposition.h: cppcheck++

2021-06-18  Gilles Caulier <caulier.gilles@gmail.com>

	* core/tests/geolocation/geoiface/demo/mytreewidget.cpp: cppcheck++


2021-06-18  Gilles Caulier <caulier.gilles@gmail.com>

	* project/reports/clangscan.sh, project/reports/clangtidy.sh,
	project/reports/clazy.sh, project/reports/cppcheck.sh,
	project/reports/krazy.sh: fix if statement

2021-06-18  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/database/item/containers/itemposition.cpp: cppcheck++

2021-06-18  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/database/item/containers/itemcomments.cpp,
	core/libs/database/item/containers/itemcomments.h: cppcheck++

2021-06-18  Gilles Caulier <caulier.gilles@gmail.com>

	* project/reports/clangscan.sh, project/reports/clangtidy.sh,
	project/reports/clazy.sh, project/reports/cppcheck.sh,
	project/reports/krazy.sh: add new option from command line to not
	update remote web site with static analyzer results

2021-06-18  Gilles Caulier <caulier.gilles@gmail.com>

	* core/libs/database/haar/haariface.cpp,
	core/libs/database/haar/haariface.h: cppcheck++

2021-06-18  Gilles Caulier <caulier.gilles@gmail.com>

	* core/dplugins/editor/enhance/healingclone/healingclonetool.cpp,
	core/dplugins/editor/enhance/healingclone/healingclonetool.h: 
	cppcheck++

2021-06-18  Gilles Caulier <caulier.gilles@gmail.com>
