2022-02-01 19:29:46 +0100 Timo Sirainen <timo.sirainen@open-xchange.com> (9dd8408c18)

    NEWS: Update news for 2.3.18 - final fixups


M	NEWS

2022-02-01 14:57:16 +0100 Timo Sirainen <timo.sirainen@open-xchange.com> (322b628350)

    lmtp: proxy - Add per-connection counter to session_id

    This way connections to two different backends don't try to use the same 
    session_id. Add 'P' letter before the counter to clarify that it's the proxy
    connection counter.

M	src/lmtp/lmtp-proxy.c

2022-02-01 14:40:48 +0100 Timo Sirainen <timo.sirainen@open-xchange.com> (88e433c4bc)

    lmtp: Simplify/clarify per-recipient session ID

    The session ID is the transaction ID followed by an increasing recipient 
    count (number of RCPT commands) in the SMTP transaction. Clarify this by 
    adding 'R' letter before the counter. Also don't add the counter suffix at 
    all for the first recipient, since most transactions only have a single 
    recipient.

M	src/lmtp/lmtp-recipient.c

2022-02-01 14:35:05 +0100 Timo Sirainen <timo.sirainen@open-xchange.com> (8bea1eb406)

    lib-smtp: server-transaction - Simplify/clarify transaction ID

    The transaction ID is the session ID followed by an increasing transaction 
    count (number of MAIL commands) in the SMTP server connection. Clarify this
    by adding 'T' letter before the counter. Also don't add the counter suffix
    at all for the first session, since most sessions only have a single
    transaction.

M	src/lib-smtp/smtp-server-transaction.c

2022-02-01 14:29:43 +0100 Timo Sirainen <timo.sirainen@open-xchange.com> (1cf8896fbc)

    lib-smtp, lmtp: Add brackets to <session-id> in logging

    This makes it clearer where the session-id stops. It's also similar to how
    it is in mail_log_prefix.

M	src/lib-smtp/smtp-server-transaction.c
M	src/lmtp/lmtp-proxy.c

2022-02-01 15:03:15 +0100 Timo Sirainen <timo.sirainen@open-xchange.com> (ba99d43d51)

    lmtp: proxy - Use recipient-specific session-id when logging the result

    Instead of transaction ID, which is shared between recipients.

M	src/lmtp/lmtp-proxy.c

2022-02-01 16:00:36 +0100 Timo Sirainen <timo.sirainen@open-xchange.com> (ff36b05302)

    lmtp: struct lmtp_recipient - Change all strings to const


M	src/lmtp/lmtp-recipient.h

2022-01-12 11:34:02 +0200 Aki Tuomi <aki.tuomi@open-xchange.com> (6bc6b14d0b)

    NEWS: Update news for 2.3.18


M	NEWS

2021-11-30 12:47:52 +0200 Aki Tuomi <aki.tuomi@open-xchange.com> (8a31667173)

    NEWS: Add news for 2.3.17.1


M	NEWS

2021-09-28 12:40:29 +0300 Aki Tuomi <aki.tuomi@open-xchange.com> (849f5028e5)

    NEWS: Add news for 2.3.17


M	NEWS

2022-01-26 04:00:32 +0100 Stephan Bosch <stephan.bosch@open-xchange.com> (b840365e30)

    lib-smtp: test-smtp-client-errors - Add test for succesful authentication
    with large initial response.


M	src/lib-smtp/test-smtp-client-errors.c

2022-01-26 03:58:49 +0100 Stephan Bosch <stephan.bosch@open-xchange.com> (a286f4cde0)

    lib-smtp: smtp-client-connection - Fix authentication with multi-roundtrip
    SASL mechanisms.

    Before, it would fail with an unexpected reply error.

M	src/lib-smtp/smtp-client-connection.c
M	src/lib-smtp/smtp-client-private.h

2022-01-24 01:39:19 +0100 Stephan Bosch <stephan.bosch@open-xchange.com> (3339fe6558)

    lib-smtp: test-smtp-client-errors - Add test for successful authentication.


M	src/lib-smtp/test-smtp-client-errors.c

2022-01-24 01:41:15 +0100 Stephan Bosch <stephan.bosch@open-xchange.com> (ee934b6890)

    lib-smtp: test-smtp-client-errors - Rename "authentication failed" test to
    "authentication".


M	src/lib-smtp/test-smtp-client-errors.c

2022-01-28 03:14:16 +0100 Stephan Bosch <stephan.bosch@open-xchange.com> (e6ce77ae69)

    lib-smtp: smtp-client - Fix maximum line length to include CRLF.


M	src/lib-smtp/smtp-client-private.h

2022-01-21 01:08:31 +0100 Stephan Bosch <stephan.bosch@open-xchange.com> (a627b9eb8f)

    lib-smtp: smtp-client-connection - Do not include initial response in AUTH
    command if it is too long.


M	src/lib-smtp/smtp-client-connection.c
M	src/lib-smtp/smtp-client-private.h

2022-01-21 02:26:18 +0100 Stephan Bosch <stephan.bosch@open-xchange.com> (67e4f2e5e2)

    lib-smtp: smtp-client-connection - Move auth cleanup to separate function.


M	src/lib-smtp/smtp-client-connection.c

2022-01-28 03:17:59 +0100 Stephan Bosch <stephan.bosch@open-xchange.com> (d09e6f8f2a)

    lib-sasl: dsasl-client - Make dsasl_client_free(&NULL) a no-op.


M	src/lib-sasl/dsasl-client.c
M	src/lib-smtp/smtp-client-connection.c
M	src/login-common/client-common-auth.c
M	src/login-common/client-common.c

2022-01-21 02:28:23 +0100 Stephan Bosch <stephan.bosch@open-xchange.com> (0f547c86e4)

    lib-smtp: smtp-client-connection - Reformat comment.


M	src/lib-smtp/smtp-client-connection.c

2022-01-26 19:28:33 +0100 Timo Sirainen <timo.sirainen@open-xchange.com> (53caa9a764)

    indexer: Fix memory leak - worker_requests were never freed

    Broken by 141766b24f885259508ae39f2e18811018373bc7

M	src/indexer/indexer.c
M	src/indexer/worker-connection.c
M	src/indexer/worker-connection.h

2022-01-25 23:31:34 +0100 Timo Sirainen <timo.sirainen@open-xchange.com> (17749f38b6)

    indexer: Fix memory leak - session IDs were never freed

    Broken by a8dcd4e2332c73087e9b148d34259230a77edb28

M	src/indexer/indexer-queue.c

2022-01-21 16:31:04 +0200 Timo Sirainen <timo.sirainen@open-xchange.com> (eaa1be2332)

    doveadm fetch/search: Use DOVEADM_MAIL_ITER_FLAG_STOP_WITH_CLIENT

    These commands only write output to the client, so it's safe to stop them if
    the client disconnects.

M	src/doveadm/doveadm-mail-fetch.c
M	src/doveadm/doveadm-mail-search.c

2022-01-21 16:29:48 +0200 Timo Sirainen <timo.sirainen@open-xchange.com> (26814caa6c)

    doveadm: doveadm_mail_iter_init() - Add
    DOVEADM_MAIL_ITER_FLAG_STOP_WITH_CLIENT

    When this flag is used, the iteration is stopped if print ostream has 
    reported an error, i.e. doveadm-client has disconnected.

M	src/doveadm/doveadm-mail-iter.c
M	src/doveadm/doveadm-mail-iter.h

2022-01-21 16:24:39 +0200 Timo Sirainen <timo.sirainen@open-xchange.com> (e9255de220)

    doveadm: doveadm_mail_iter_init() - Change bool parameter to flags


M	src/doveadm/doveadm-mail-altmove.c
M	src/doveadm/doveadm-mail-copymove.c
M	src/doveadm/doveadm-mail-deduplicate.c
M	src/doveadm/doveadm-mail-expunge.c
M	src/doveadm/doveadm-mail-fetch.c
M	src/doveadm/doveadm-mail-flags.c
M	src/doveadm/doveadm-mail-import.c
M	src/doveadm/doveadm-mail-iter.c
M	src/doveadm/doveadm-mail-iter.h
M	src/doveadm/doveadm-mail-mailbox-cache.c
M	src/doveadm/doveadm-mail-rebuild.c
M	src/doveadm/doveadm-mail-search.c

2022-01-20 14:16:51 +0100 Timo Sirainen <timo.sirainen@open-xchange.com> (d9a95e03d9)

    doveadm-server: Fix hang when flushing print output and client disconnects


M	src/doveadm/doveadm-print-server.c

2022-01-20 14:13:48 +0100 Timo Sirainen <timo.sirainen@open-xchange.com> (f655383d87)

    lib: ostream-multiplex - Call flush callbacks also when stream has failed

    It may be important for the flush callbacks to know when ostream has been 
    closed. This is a partial fix to prevent doveadm-server hanging when it's 
    printing lots of output and doveadm client disconnects.

M	src/lib/ostream-multiplex.c

2022-01-20 13:34:50 +0100 Timo Sirainen <timo.sirainen@open-xchange.com> (16c76b2641)

    doveadm: Fix assert-crash when proxying causes print buffer to be flushed

    Fixes: Panic: file ioloop.c: line 865 (io_loop_destroy): assertion failed:
    (ioloop == current_ioloop)

M	src/doveadm/doveadm-print-server.c

2022-01-20 12:42:57 +0200 Timo Sirainen <timo.sirainen@open-xchange.com> (560f11bd12)

    lib-storage: Don't delay setting mail event's log prefix

    This caused crashes if the mail event was kept referenced and used for 
    logging after struct mail was already freed. With the delayed mail event 
    creation the log prefix shouldn't be much of a performance problem, so just 
    set the prefix immediately.

    Partially reverts bc68e1c368db746557829f67556f3c72943b7956.

M	src/lib-storage/mail.c

2022-01-12 10:41:20 +0200 Aki Tuomi <aki.tuomi@open-xchange.com> (6efac6ba28)

    configure: Set version to 2.3.18


M	configure.ac

2022-01-10 19:46:12 +0200 Timo Sirainen <timo.sirainen@open-xchange.com> (26c5c2aa2b)

    lib-storage: Remove reason_code=mailbox:search

    Continues the slow per-mail event removals started in 
    f3c568e3cbc113920bc029e07e56619589c6a26d.

    Reverts 87cd6570a14b3f572fc6000f710df409371a4bcb

M	src/lib-storage/index/index-search.c

2021-12-13 12:54:19 +0100 Stephan Bosch <stephan.bosch@open-xchange.com> (c043787771)

    lmtp: lmtp-proxy - Add session ID to backend connection error replies.


M	src/lmtp/lmtp-proxy.c

2021-12-13 04:08:32 +0100 Stephan Bosch <stephan.bosch@open-xchange.com> (b29d0df2ef)

    submssion: submission-backend-relay - Avoid logging two errors about a
    connection problem.

    Earlier commit changed lib-smtp to consistently log an error for connection 
    problems, which causes a second error to occur for submission relay backend. 
    This is undesirable.

M	src/submission/submission-backend-relay.c

2021-12-07 01:51:45 +0100 Stephan Bosch <stephan.bosch@open-xchange.com> (08d650cb81)

    lmtp: lmtp-proxy - Add lmtp_verbose_replies setting.

    It causes the proxy to return errors with full details in replies to the
    LMTP client.

M	src/lmtp/lmtp-proxy.c
M	src/lmtp/lmtp-settings.c
M	src/lmtp/lmtp-settings.h

2021-12-27 11:35:05 +0100 Stephan Bosch <stephan.bosch@open-xchange.com> (a0cd85f004)

    lmtp: lmtp-proxy - Split off lmtp_proxy_handle_connection_error().


M	src/lmtp/lmtp-proxy.c

2022-01-04 21:20:22 +0100 Stephan Bosch <stephan.bosch@open-xchange.com> (1d88bdfdf8)

    lmtp: lmtp-proxy - Change proxy connection failure message make more sense.


M	src/lmtp/lmtp-proxy.c

2021-12-07 01:58:32 +0100 Stephan Bosch <stephan.bosch@open-xchange.com> (11b6ccdfce)

    lib-smtp: smtp-client - Add verbose_user_errors setting.

    It returns the detailed administrator errors as user error in the reply
    returned to the calling application.

M	src/lib-smtp/smtp-client-connection.c
M	src/lib-smtp/smtp-client.c
M	src/lib-smtp/smtp-client.h

2021-12-07 01:51:18 +0100 Stephan Bosch <stephan.bosch@open-xchange.com> (40d49a038b)

    lib-smtp: smtp-client-connection - Log administrator connection failures at
    a single place.


M	src/lib-smtp/smtp-client-command.c
M	src/lib-smtp/smtp-client-connection.c
M	src/lib-smtp/smtp-client-private.h

2021-12-23 00:59:45 +0100 Stephan Bosch <stephan.bosch@open-xchange.com> (f436df8709)

    lib-smtp: smtp-client-connection - Consistently log an error for connection
    failures.


M	src/lib-smtp/smtp-client-connection.c
M	src/lib-smtp/test-smtp-client-errors.c

2021-12-07 02:44:58 +0100 Stephan Bosch <stephan.bosch@open-xchange.com> (5ef51c52ef)

    lib-smtp: smtp-client-connection - Add definition for repeatedly used
    connection error.


M	src/lib-smtp/smtp-client-connection.c

2021-12-27 11:24:36 +0100 Stephan Bosch <stephan.bosch@open-xchange.com> (06f838091b)

    lmtp: Reformat lmtp-proxy.c.


M	src/lmtp/lmtp-proxy.c

2021-12-07 01:23:13 +0100 Stephan Bosch <stephan.bosch@open-xchange.com> (2e82fdb706)

    lib-smtp: Reformat smtp-client-connection.c.


M	src/lib-smtp/smtp-client-connection.c

2022-01-05 01:27:48 +0000 Stephan Bosch <stephan.bosch@dovecot.fi> (3575639fc4)

    lib-compression: ostream-zlib - Fix signed vs unsigned comparison.


M	src/lib-compression/ostream-zlib.c

2022-01-05 01:25:34 +0000 Stephan Bosch <stephan.bosch@dovecot.fi> (5108d7bddd)

    lib: test-event-flatten - Fix format string specifier for usec time


M	src/lib/test-event-flatten.c

2021-12-28 09:37:42 +0200 Timo Sirainen <timo.sirainen@open-xchange.com> (f3c568e3cb)

    lib-storage: Remove most reason_code=mail:*

    Event reasons create events internally. This is rather expensive if it's 
    done for operations that access all emails in a large folder, e.g. SORT. The
    per-mail reason_codes also didn't seem to be hugely helpful, so best to just
    remove them.

    Some of the mail:* reasons were left where they are causing mail stream to 
    be opened anyway. In these cases the extra CPU used by event reasons is 
    relatively little.

    Reverts ce517f8323fa4a60b230f29712b207139badb3f0

M	src/lib-storage/index/index-mail.c
M	src/lib-storage/mail.c

2021-12-20 11:05:39 +0200 Timo Sirainen <timo.sirainen@open-xchange.com> (ac4d66e25e)

    maildir: maildir_filename_base_hash() - Disable ubsan integer wrapping
    checks


M	src/lib-storage/index/maildir/maildir-filename.c

2021-12-09 18:06:11 +0100 Timo Sirainen <timo.sirainen@open-xchange.com> (ac7bcc31c9)

    lib-fts: Reuse textcat handle between sessions

    textcat initialization is rather CPU intensive. Its configuration is 
    normally always the same between sessions, so we can keep the latest textcat 
    handle cached.

M	src/lib-fts/fts-language.c

2021-11-29 17:05:18 +0100 Timo Sirainen <timo.sirainen@open-xchange.com> (fd7248b707)

    lib-storage: Remove index_mail_data.seq

    The seq already exists in struct mail, so this unnecessarily duplicated it.

M	src/lib-storage/index/index-mail-headers.c
M	src/lib-storage/index/index-mail.c
M	src/lib-storage/index/index-mail.h

2021-11-29 16:21:29 +0100 Timo Sirainen <timo.sirainen@open-xchange.com> (767b689cfb)

    lib-storage: Minor optimization - Use mail_index_lookup_full() to avoid two
    index lookups

    mail_index_is_expunged() was already internally doing the full lookup.

M	src/lib-storage/index/index-mail.c

2021-11-29 16:16:30 +0100 Timo Sirainen <timo.sirainen@open-xchange.com> (526a0f5b18)

    lib-index: mail_index_lookup_full() - Add expunged_r parameter


M	src/lib-index/mail-index-modseq.c
M	src/lib-index/mail-index-view.c
M	src/lib-index/mail-index.h

2021-11-29 13:26:25 +0100 Timo Sirainen <timo.sirainen@open-xchange.com> (bc68e1c368)

    lib-storage: Optimize setting mail event log prefix

    This was much more important before mail event creation was delayed. In one 
    installation the t_strdup_printf() call itself took about 4% of the total
    CPU usage. Now that mail events are delayed, this is likely much less of an
    issue. Still, this is easy enough of an optimization that might as well do
    it.

M	src/lib-storage/mail.c

2021-11-29 15:46:04 +0100 Timo Sirainen <timo.sirainen@open-xchange.com> (165be3edb6)

    lib-storage: Delay creating mail event until mail_event() is called

    Mails can be accessed a lot. The event handling code takes up a lot of CPU, 
    but most of the time the created event wasn't actually used for anything.

M	src/lib-storage/index/index-mail.c
M	src/lib-storage/mail-storage-private.h
M	src/lib-storage/mail-storage.h
M	src/lib-storage/mail.c

2021-11-29 15:43:29 +0100 Timo Sirainen <timo.sirainen@open-xchange.com> (a24e4a14f9)

    lib-storage: Make sure mail event is created before accessing streams or
    metadata

    This is in preparation for the next commit which delays the mail event 
    creation. The event duration behaves better if the event is created before 
    any potentially slow access is done.

M	src/lib-storage/mail-storage-private.h
M	src/lib-storage/mail.c

2021-11-29 15:36:58 +0100 Timo Sirainen <timo.sirainen@open-xchange.com> (58eef6713e)

    lib-storage: Move struct mail.event to mail_private


M	src/lib-storage/index/index-mail.c
M	src/lib-storage/mail-storage-private.h
M	src/lib-storage/mail-storage.h
M	src/lib-storage/mail.c

2021-11-29 15:32:28 +0100 Timo Sirainen <timo.sirainen@open-xchange.com> (b0596718ab)

    lib-lda, lib-storage: Use mail_event()


M	src/lib-lda/mail-send.c
M	src/lib-storage/mail.c

2021-11-29 15:31:17 +0100 Timo Sirainen <timo.sirainen@open-xchange.com> (4b3775baf0)

    lib-storage: Add mail_event()


M	src/lib-storage/mail-storage.h
M	src/lib-storage/mail.c

2021-11-29 18:39:22 +0100 Timo Sirainen <timo.sirainen@open-xchange.com> (13fd3c3256)

    lib-storage: Add and use mail_metadata_access_start()


M	src/lib-storage/index/maildir/maildir-mail.c
M	src/lib-storage/index/raw/raw-mail.c
M	src/lib-storage/mail-storage-private.h
M	src/lib-storage/mail.c

2021-11-29 18:32:09 +0100 Timo Sirainen <timo.sirainen@open-xchange.com> (988a575c35)

    lib-storage: Add and use mail_stream_access_start()

    This replaces setting mail_stream_accessed directly.

M	src/lib-storage/index/dbox-multi/mdbox-mail.c
M	src/lib-storage/index/dbox-single/sdbox-mail.c
M	src/lib-storage/index/imapc/imapc-mail-fetch.c
M	src/lib-storage/index/imapc/imapc-save.c
M	src/lib-storage/index/index-mail.c
M	src/lib-storage/index/maildir/maildir-mail.c
M	src/lib-storage/index/mbox/mbox-mail.c
M	src/lib-storage/index/pop3c/pop3c-mail.c
M	src/lib-storage/index/raw/raw-mail.c
M	src/lib-storage/mail-storage-private.h
M	src/lib-storage/mail.c

2021-11-29 18:35:31 +0100 Timo Sirainen <timo.sirainen@open-xchange.com> (e06ee029f6)

    lib-storage: raw: get_stream() - Add missing lookup_abort and
    mail_stream_accessed handling


M	src/lib-storage/index/raw/raw-mail.c

2021-11-29 18:34:43 +0100 Timo Sirainen <timo.sirainen@open-xchange.com> (2f2e3b3d37)

    pop3c: Add missing lookup_abort and mail_stream_accessed handling


M	src/lib-storage/index/pop3c/pop3c-mail.c

2021-11-29 20:44:05 +0100 Timo Sirainen <timo.sirainen@open-xchange.com> (5b97f3af04)

    maildir: get_stream() - Add missing lookup_abort and mail_stream_accessed
    handling


M	src/lib-storage/index/maildir/maildir-mail.c

2021-11-29 18:24:30 +0100 Timo Sirainen <timo.sirainen@open-xchange.com> (d7b8c40971)

    lib-storage: Rename mail.mail_stream_opened to mail_stream_accessed

    It is set to TRUE even if the mail stream couldn't successfully be opened, 
    so this describes it better. Also it's now consistent with 
    mail_metadata_accessed.

M	src/lib-storage/index/dbox-multi/mdbox-mail.c
M	src/lib-storage/index/dbox-single/sdbox-mail.c
M	src/lib-storage/index/imapc/imapc-mail-fetch.c
M	src/lib-storage/index/index-mail.c
M	src/lib-storage/index/index-mailbox-size.c
M	src/lib-storage/index/index-sort.c
M	src/lib-storage/index/mbox/mbox-mail.c
M	src/lib-storage/mail-storage.h

2021-12-03 10:44:10 +0200 Timo Sirainen <timo.sirainen@open-xchange.com> (74b94e02e5)

    lib-index: Remove mail_cache_lookup_finished event

    This event was using too much CPU with commands that accessed lots of mails
    (e.g. IMAP SORT). It also wasn't especially useful.

    Reverts 0d252dccb3013fea4d9a28bd5fafb5ea6e847d0e

M	src/lib-index/mail-cache-lookup.c

2021-12-02 11:35:20 +0200 Timo Sirainen <timo.sirainen@open-xchange.com> (1fb3dda9ac)

    lib-index: Use ATTR_COLD for error/corruption handling functions

    This could reduce CPU usage due to better branch prediction.

M	src/lib-index/mail-cache-private.h
M	src/lib-index/mail-cache.h
M	src/lib-index/mail-index-private.h
M	src/lib-index/mail-index-strmap.h
M	src/lib-index/mail-index-sync-private.h
M	src/lib-index/mail-index.h
M	src/lib-index/mail-transaction-log-private.h
M	src/lib-index/mail-transaction-log.h

2021-11-23 15:00:02 +0100 Timo Sirainen <timo.sirainen@open-xchange.com> (4a74574d39)

    lib: pool_alloconly_destroy() optimization - Don't clear the last block
    before free

    The block is going to be freed, so there's no need to clear it.
    (The clearing still happens if clean_frees=TRUE.)

M	src/lib/mempool-alloconly.c

2021-11-23 14:59:28 +0100 Timo Sirainen <timo.sirainen@open-xchange.com> (40666e3bca)

    lib: pool_alloconly_destroy() - Deduplicate code


M	src/lib/mempool-alloconly.c

2021-11-23 14:58:39 +0100 Timo Sirainen <timo.sirainen@open-xchange.com> (7c9ee911cf)

    lib: Split off pool_alloconly_free_block()


M	src/lib/mempool-alloconly.c

2021-11-23 14:56:10 +0100 Timo Sirainen <timo.sirainen@open-xchange.com> (333bd2e628)

    lib: Split off pool_alloconly_free_blocks_until_last()


M	src/lib/mempool-alloconly.c

2021-11-23 15:17:49 +0200 Timo Sirainen <timo.sirainen@open-xchange.com> (0bcc6897de)

    lib: Minor optimization - Avoid zeroing a newly created empty event field


M	src/lib/lib-event.c

2021-11-22 17:36:21 +0100 Timo Sirainen <timo.sirainen@open-xchange.com> (9fc6965de1)

    lib: Remove copy of event_passthrough from struct event

    There was no need for it. This saves some memory and CPU.

    This change now prevents modifications to the event_passthrough, but nothing 
    was doing it before either.

M	src/lib/lib-event-private.h
M	src/lib/lib-event.c

2021-11-22 17:23:28 +0100 Timo Sirainen <timo.sirainen@open-xchange.com> (a2ea3df64f)

    lib: Grow initial event pool size to 1024 bytes

    The old 64 bytes size wasn't enough to allocate even the struct event
    itself.

M	src/lib/lib-event.c

2021-12-15 09:19:40 +0100 Karl Fleischmann <karl.fleischmann@open-xchange.com> (793cae8549)

    login-common: Explicitly null client auth fields on proxy pool unref

    Explicitly setting `client_id` and `forward_fields` to null in the client
    may reveal use-after-free issues when trying to access these fields on a
    client proxy.

M	src/login-common/client-common.c

2021-12-10 11:04:06 +0100 Karl Fleischmann <karl.fleischmann@open-xchange.com> (7ad1a92aa5)

    login-common: Use base index for aliases

    Define a base index for aliases in the login variable table. Assign values
    via offset of that base index. This allows adding more values later without
    updating any subsequent index.

M	src/login-common/client-common.c

2021-12-10 11:32:37 +0100 Marco Bettini <marco.bettini@open-xchange.com> (ddb85f3533)

    fts: Add headers filters


M	src/plugins/fts/fts-api-private.h
M	src/plugins/fts/fts-api.c
M	src/plugins/fts/fts-build-mail.c

2021-12-10 11:30:08 +0100 Marco Bettini <marco.bettini@open-xchange.com> (24b66ca063)

    fts: fts-build-mail - Remove stray line


M	src/plugins/fts/fts-build-mail.c

2020-11-10 00:11:15 +0100 Stephan Bosch <stephan.bosch@open-xchange.com> (a92209788d)

    auth: mech-scram - Amend comments.


M	src/auth/mech-scram.c

2020-11-10 00:11:11 +0100 Stephan Bosch <stephan.bosch@open-xchange.com> (49b5780c29)

    auth: mech-scram - Fix handling of authzid.

    The gs2-header field was not recreated correctly for the final verification. 
    Fixed by storing the complete gs2-header value instead.

M	src/auth/mech-scram.c

2020-11-10 00:11:07 +0100 Stephan Bosch <stephan.bosch@open-xchange.com> (a164ea3786)

    auth: mech-scram - Properly size temporary string buffers.


M	src/auth/mech-scram.c

2020-11-10 00:11:03 +0100 Stephan Bosch <stephan.bosch@open-xchange.com> (1ee7d0d807)

    auth: mech-scram - Restructure message parsing in
    parse_scram_client_first().


M	src/auth/mech-scram.c

2020-11-10 00:10:57 +0100 Stephan Bosch <stephan.bosch@open-xchange.com> (6678648cfb)

    auth: Reformat mech-scram.c.


M	src/auth/mech-scram.c

2021-08-20 17:43:09 +0300 Timo Sirainen <timo.sirainen@open-xchange.com> (15f25bf7ad)

    lib-storage: Return reason string in mailbox_vfuncs.list_index_has_changed()

    The callers can use it to log why the list index had changed.

M	src/lib-storage/index/index-storage.h
M	src/lib-storage/index/index-sync.c
M	src/lib-storage/index/maildir/maildir-sync-index.c
M	src/lib-storage/index/maildir/maildir-sync.h
M	src/lib-storage/index/mbox/mbox-sync-list-index.c
M	src/lib-storage/index/mbox/mbox-sync-private.h
M	src/lib-storage/list/mailbox-list-index-status.c
M	src/lib-storage/list/mailbox-list-index.c
M	src/lib-storage/mail-storage-private.h
M	src/plugins/virtual/virtual-storage.c

2021-08-20 19:09:17 +0300 Timo Sirainen <timo.sirainen@open-xchange.com> (e13768d2ee)

    lib-storage: Don't call mailbox_vfuncs.list_index_has_changed() in data
    stack frame

    This will be required by the next change.

M	src/lib-storage/list/mailbox-list-index-iter.c
M	src/lib-storage/list/mailbox-list-index-status.c
M	src/lib-storage/list/mailbox-list-index.c

2021-08-20 17:26:42 +0300 Timo Sirainen <timo.sirainen@open-xchange.com> (6fb3e493e2)

    lib-storage: mailbox_list_index_view_open() - Log a debug line why index
    isn't up-to-date


M	src/lib-storage/list/mailbox-list-index.c

2021-08-20 17:20:01 +0300 Timo Sirainen <timo.sirainen@open-xchange.com> (49d2d1d9ba)

    lib-storage: mailbox_list_index_status() - Return failure reason string

    Log a debug line if mailbox list index couldn't be used to get the wanted 
    status information.

M	src/lib-storage/list/mailbox-list-index-backend.c
M	src/lib-storage/list/mailbox-list-index-notify.c
M	src/lib-storage/list/mailbox-list-index-status.c
M	src/lib-storage/list/mailbox-list-index.h
M	src/lib-storage/list/mailbox-list-notify-tree.c

2021-12-06 11:54:16 +0100 Marco Bettini <marco.bettini@open-xchange.com> (7751299dee)

    auth: userdb-ldap - Avoid early dereferencing

    userdb_ldap_iterate_callback() is still invoked after dereferencing 
    auth_request in userdb_ldap_iterate_deinit().

    Normally this happens only on teardown, but it may happens also in case of
    auth disconnecting from auth-worker during iteration.
    (which shouldn't happen unless the auth process crashes)

M	src/auth/userdb-ldap.c

2021-12-09 17:31:04 +0100 Timo Sirainen <timo.sirainen@open-xchange.com> (2302fcd607)

    var-expand-crypt: Remove dead code

    It's correct that dcrypt library shouldn't be deinitialized at plugin 
    deinit.

M	src/plugins/var-expand-crypt/var-expand-crypt-plugin.c

2021-12-03 17:23:35 +0200 Timo Sirainen <timo.sirainen@open-xchange.com> (82be40f65c)

    login-common: Add more fields to proxy_session_finished

    Added disconnect_side, disconnect_reason, idle_secs, bytes_in, bytes_out.

M	src/login-common/login-proxy.c

2021-12-03 17:54:37 +0200 Timo Sirainen <timo.sirainen@open-xchange.com> (da379cfc29)

    login-common: Split off proxy disconnection prefix to
    LOGIN_PROXY_KILL_PREFIX


M	src/login-common/login-proxy.c

2021-12-03 17:47:50 +0200 Timo Sirainen <timo.sirainen@open-xchange.com> (d36139fc22)

    login-common: login_proxy_free_*() - Rename reason to log_msg

    This better describes it, since it's the full log message.

M	src/login-common/login-proxy.c

2021-12-01 14:46:04 +0200 Timo Sirainen <timo.sirainen@open-xchange.com> (203147d0fc)

    dsync: Fix -I max-size to actually be the max-size rather than min-size

    The -I max-size parameter was supposed to be used to skip mails that are 
    larger than max-size. Instead, it skipped mails that were smaller.

M	src/doveadm/dsync/dsync-mailbox-import.c

2021-11-09 13:42:24 +0100 Timo Sirainen <timo.sirainen@open-xchange.com> (34f2fdeed5)

    man: Add missing parameters to doveadm-sync


M	doc/man/doveadm-sync.1.in

2021-11-30 18:02:14 +0200 Timo Sirainen <timo.sirainen@open-xchange.com> (e6a5cb57d1)

    dsync: Remove -D parameter that disables syncing mailbox renames

    It hasn't been necessary for a long time, and its behavior seems to be 
    broken.

M	src/doveadm/doveadm-dsync.c
M	src/doveadm/dsync/dsync-brain-mailbox-tree.c
M	src/doveadm/dsync/dsync-brain-private.h
M	src/doveadm/dsync/dsync-brain.c
M	src/doveadm/dsync/dsync-brain.h
M	src/doveadm/dsync/dsync-ibc-stream.c

2021-11-09 13:41:37 +0100 Timo Sirainen <timo.sirainen@open-xchange.com> (96f9651c98)

    dsync: Add back various missing parameters

    Also add them to the usage string.

    Broken by 5676c510bfa9217df05e9b7cb000ae3554d66f22

M	src/doveadm/doveadm-dsync.c

2021-09-22 14:50:50 -0600 Michael M Slusarz <michael.slusarz@open-xchange.com> (2beae65898)

    fts: Don't overwrite INUSE error if indexing times out


M	src/plugins/fts/fts-indexer.c
M	src/plugins/fts/fts-storage.c

2021-11-11 12:31:49 +0200 Aki Tuomi <aki.tuomi@open-xchange.com> (61d9023523)

    lib-storage/index: If mail stream was already opened, do not count it as
    slow vsize access

    imapc storage driver will open the mail stream in some circumstances during
    search, so do not consider this as slow vsize.

M	src/lib-storage/index/index-mailbox-size.c

2021-11-16 15:08:47 +0200 Aki Tuomi <aki.tuomi@open-xchange.com> (73475e1ea6)

    lib-storage: Split off index_mailbox_vsize_finish_bg()

    Simplifies next commit

M	src/lib-storage/index/index-mailbox-size.c

2021-08-10 12:22:08 +0300 Timo Sirainen <timo.sirainen@open-xchange.com> (1ee84ba065)

    lib-index: Fix storing cache fields' last_used with 64bit big endian CPUs


M	src/lib-index/mail-cache-fields.c

2019-01-17 12:13:38 +0200 Timo Sirainen <timo.sirainen@open-xchange.com> (616684a8fe)

    maildir: Fix crash at error handling

    At this point dest_mail is already NULL. Mainly could happen when running 
    out of disk space.

M	src/lib-storage/index/maildir/maildir-save.c

2021-11-30 09:51:25 +0000 Siavash Tavakoli <siavash.tavakoli@open-xchange.com> (ea41bf7db1)

    login-proxy: Don't send proxying start event for reconnects

    Send the event only for the beginning of proxying and add the reconnect
    counts as a field for _established and _finished events.

M	src/login-common/login-proxy.c

2021-11-26 14:45:47 +0100 Marco Bettini <marco.bettini@open-xchange.com> (2f7254a6af)

    lib: str_parse_intmax() - Replace signed expression with UNSIGNED_MINUS()

    Found by code analysis tool

M	src/lib/strnum.c

2021-11-26 15:48:04 +0100 Marco Bettini <marco.bettini@open-xchange.com> (5297d4862f)

    lib: switch i_rand_limit() - Replace signed expression with UNSIGNED_MINUS()

    Found by code analysis tool

M	src/lib/rand.c

2021-11-26 14:15:07 +0100 Marco Bettini <marco.bettini@open-xchange.com> (4a3ef239b4)

    lib: buffer_truncate_rshift_bits() - Replace signed expression with an
    unsigned equivalent

    Found by code analysis tool

M	src/lib/buffer.c

2021-11-29 15:05:29 +0100 Marco Bettini <marco.bettini@open-xchange.com> (668bdc6838)

    lib: bits_rotXYY() - Replace signed expression with UNSIGNED_MINUS() macro
    for unsigned 2's complement

    Found by code analysis tool

M	src/lib/bits.h
M	src/lib/test-bits.c

2021-11-29 15:00:41 +0100 Marco Bettini <marco.bettini@open-xchange.com> (bf9c2cb8b5)

    bits_is_power_of_two() Replace signed expression with __builtin_popcountl()

    Found by code analysis tool

M	src/lib/bits.h
M	src/lib/test-bits.c

2021-11-29 14:58:33 +0100 Marco Bettini <marco.bettini@open-xchange.com> (f7cbaac8ff)

    lib: test-bits.c - Removing stray spaces at end of lines


M	src/lib/test-bits.c

2021-01-15 17:43:19 +0100 Fabrice Bellet <fabrice@bellet.info> (9211e803f2)

    raw-storage: copy the envelope sender instead of referencing it


M	src/lib-storage/index/raw/raw-storage.c

2019-10-14 16:43:57 +0300 Timo Sirainen <timo.sirainen@open-xchange.com> (4a58d467b6)

    lib-fs: Add test-fs utility for testing fs drivers

    It performs random read/write/delete/iter operations.

M	src/util/Makefile.am
A	src/util/test-fs.c

2021-06-18 15:19:48 +0300 Timo Sirainen <timo.sirainen@open-xchange.com> (051d39ee45)

    replicator: doveadm replicator replicate -f didn't always start full sync

    The full sync happened only if the dsync queue was already full. If it 
    wasn't, dsync was called too early before user->force_full_sync was set.

M	src/replication/replicator/replicator-brain.c

2021-07-28 11:52:01 +0300 Timo Sirainen <timo.sirainen@open-xchange.com> (d0c28bba8b)

