#1151 Fluxbox-1.3.7: can't change window manager without logging out

v1.3.7
open
nobody
None
5
6 days ago
7 days ago
No

Hello,

As stated in this thread, any attempt to switch to another window manager from withing fluxbox (for instance, fluxbox menu > Window Managers > blackbox) leads X server to be closed.

This issue is a consequence of the alarm triggered by fluxbox::shutdown() (see this commit which fixes bug 1100).

I'm not used to fluxbox code, but, it seems that when a window manager is selected, fluxbox::restart() is called which calls fluxbox::shutdown() which triggers the alarm. However, the SIGALRM is not handled before execution of execlp() (in main.cc), which starts the selected window manager, and thus, fluxbox is killed by SIGALRM, and the selected window manager terminates unexpectedly.

The attached patch fixes this issue.

Hope this help.

--
SeB

1 Attachments

Discussion

  • Mathias Gumz

    Mathias Gumz - 7 days ago

    interesting find.

    i usually restart fluxbox with fluxbox to see a new compiled binary in effect, the shutdown never happened.

    i also can not remember the reason for the alarm(2) and why i introduced it, i have to read the code a little bit =)

     
  • Thomas Luebking

    Thomas Luebking - 6 days ago

    afaiu commit 43bdf499, the actual issue was that fb restarted on SIGHUP which is unfortunately caused by xinit when exiting the session, ie. if you exited fluxbox and the session ends, fluxbox would attempt to restart and fall flat when the server is just gone.

    cancelling the alarm on shutdown would counterfeit the failsafe idea, yesno?
    I'd simply remove the alarm(2) and iff fluxbox loops around unwantedly, figure why that is and fix it?

     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks