From a493bd91d6366113178633b86dfd4703f73b520d Mon Sep 17 00:00:00 2001 From: "B. Watson" Date: Wed, 10 Jul 2024 16:28:06 -0400 Subject: chkbas: add missing left-paren to LEFT$/RIGHT$/MID$ for BXL/BXE; warn about ATASCII and mention a8cat in man page. --- jindroush/README.txt | 7 ++++--- jindroush/chkbas/basic_xe.h | 6 +++--- jindroush/chkbas/basic_xl.h | 6 +++--- jindroush/man/chkbas.1 | 18 +++++++++++++++++- jindroush/man/chkbas.rst | 8 ++++++++ 5 files changed, 35 insertions(+), 10 deletions(-) (limited to 'jindroush') diff --git a/jindroush/README.txt b/jindroush/README.txt index 31d9af9..a085003 100644 --- a/jindroush/README.txt +++ b/jindroush/README.txt @@ -29,9 +29,10 @@ I've made to Jindroush's code: with mode 0600; changed this to 0666 (which will still be affected by the user's umask). -- Added "listbas" symlink, to save typing "chkbas -short" over and over - again. - - adir's -dir option now creates the directory if it doesn't exist. - Wrote man pages for all the utilities. + +- Fixed a bug in chkbas: BASIC XL and XE's LEFT$ RIGHT$ MID$ were + being printed without the left parenthesis (e.g Left$(A$,3) was + coming out as Left$A$,3). diff --git a/jindroush/chkbas/basic_xe.h b/jindroush/chkbas/basic_xe.h index fc86131..56e0276 100644 --- a/jindroush/chkbas/basic_xe.h +++ b/jindroush/chkbas/basic_xe.h @@ -209,9 +209,9 @@ char* aOpsBasicXe[] = { "ERR", //63 "TAB", //64 "PEN", //65 - "LEFT$", //66 - "RIGHT$", //67 - "MID$", //68 + "LEFT$(", //66 + "RIGHT$(", //67 + "MID$(", //68 }; #define BASICXE_CMD_NUM ( sizeof( aCmdsBasicXe ) / sizeof( aCmdsBasicXe[ 0 ] ) ) diff --git a/jindroush/chkbas/basic_xl.h b/jindroush/chkbas/basic_xl.h index a97f8a7..97dd627 100644 --- a/jindroush/chkbas/basic_xl.h +++ b/jindroush/chkbas/basic_xl.h @@ -203,9 +203,9 @@ char* aOpsBasicXl[] = { "ERR", //63 "TAB", //64 "PEN", //65 - "LEFT$", //66 - "RIGHT$", //67 - "MID$", //68 + "LEFT$(", //66 + "RIGHT$(", //67 + "MID$(", //68 }; #define BASICXL_CMD_NUM ( sizeof( aCmdsBasicXl ) / sizeof( aCmdsBasicXl[ 0 ] ) ) diff --git a/jindroush/man/chkbas.1 b/jindroush/man/chkbas.1 index 1f5313a..f2664f3 100644 --- a/jindroush/man/chkbas.1 +++ b/jindroush/man/chkbas.1 @@ -27,7 +27,7 @@ level margin: \\n[rst2man-indent\\n[rst2man-indent-level]] .\" new: \\n[rst2man-indent\\n[rst2man-indent-level]] .in \\n[rst2man-indent\\n[rst2man-indent-level]]u .. -.TH "CHKBAS" 1 "2024-06-25" "1.10" "Jindroush's Atari 8-bit tools" +.TH "CHKBAS" 1 "2024-07-10" "1.10" "Jindroush's Atari 8-bit tools" .SH NAME chkbas \- check and detokenize Atari BASIC SAVEd files .SH SYNOPSIS @@ -45,6 +45,22 @@ standard output. If \fBbasic\-file\fP is anything other than standard Atari BASIC, the BASIC dialect must be specified (see \fBOPTIONS\fP, below). .sp +It\(aqs highly recommended to avoid running \fBchkbas\fP without +redirecting or piping its output: If the program contains ATASCII +graphics or inverse characters, they will be printed as\-is to the +terminal, which can confuse the terminal. For simply reading the code, +pipe to \fBa8cat\fP(1), thus: +.INDENT 0.0 +.INDENT 3.5 +.sp +.nf +.ft C +$ chkbas \-atari PROGRAM.BAS | a8cat +.ft P +.fi +.UNINDENT +.UNINDENT +.sp Sample run, with no options: .INDENT 0.0 .INDENT 3.5 diff --git a/jindroush/man/chkbas.rst b/jindroush/man/chkbas.rst index e16f475..b6c678f 100644 --- a/jindroush/man/chkbas.rst +++ b/jindroush/man/chkbas.rst @@ -28,6 +28,14 @@ standard output. If **basic-file** is anything other than standard Atari BASIC, the BASIC dialect must be specified (see **OPTIONS**, below). +It's highly recommended to avoid running **chkbas** without +redirecting or piping its output: If the program contains ATASCII +graphics or inverse characters, they will be printed as-is to the +terminal, which can confuse the terminal. For simply reading the code, +pipe to **a8cat**\(1), thus:: + + $ chkbas -atari PROGRAM.BAS | a8cat + Sample run, with no options:: $ chkbas HELLO.BAS -- cgit v1.2.3