diff options
| author | B. Watson <urchlay@slackware.uk> | 2023-06-30 20:07:45 -0400 |
|---|---|---|
| committer | B. Watson <urchlay@slackware.uk> | 2023-06-30 20:07:45 -0400 |
| commit | ba63bfe1d5e352ee12bf186261229bee1604b319 (patch) | |
| tree | 3d05319e0ab64cf210666035d7c283e0286dcbba | |
| parent | 8e1c2a8cbbfe67ca046cacb42d4e48de9b2b41c0 (diff) | |
| download | sbo-maintainer-tools-ba63bfe1d5e352ee12bf186261229bee1604b319.tar.gz | |
sbopkglint: handle symlinked static libs correctly.
| -rw-r--r-- | TODO | 3 | ||||
| -rw-r--r-- | sbopkglint.d/75-static_libs.t.sh | 6 |
2 files changed, 6 insertions, 3 deletions
@@ -1,3 +1,6 @@ +TODO: sbopkglint reports bad files in doc dir twice. +TODO: sbopkglint should check for stuff like /usr/lib/lv2 vs. /usr/lib64/lv2, + according to ARCH. see audio/helm, v0.9.0, BUILD=1 TODO: sbopkglint should check for perllocal.pod, .packlist, *.bs (see perl template). TODO: sbopkglint could complain if the SlackBuild sets SLKCFLAGS diff --git a/sbopkglint.d/75-static_libs.t.sh b/sbopkglint.d/75-static_libs.t.sh index b0cdcdd..fab2a2b 100644 --- a/sbopkglint.d/75-static_libs.t.sh +++ b/sbopkglint.d/75-static_libs.t.sh @@ -14,11 +14,11 @@ for libdir in lib lib64 usr/lib usr/lib64; do if [ -d $libdir ]; then find_warnfiles "bad static library ownership (should be root:root):" \ - $libdir -mindepth 1 -maxdepth 1 -name '*.a' \! \( -user root -a -group root \) + -L $libdir -mindepth 1 -maxdepth 1 -name '*.a' \! \( -user root -a -group root \) find_warnfiles "bad static library permissions (should be 0644 or 0444):" \ - $libdir -mindepth 1 -maxdepth 1 -name '*.a' \! \( -perm 444 -o -perm 644 \) + -L $libdir -mindepth 1 -maxdepth 1 -name '*.a' \! \( -perm 444 -o -perm 644 \) find $libdir -mindepth 1 -maxdepth 1 -name '*.a' | while read static; do - ftype="$( file -b --mime-type "$static" )" + ftype="$( file -L -b --mime-type "$static" )" case "$ftype" in "application/x-archive") ;; # OK *) warn "$static is not a valid static library. MIME type is '$ftype'." ;; |