aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorB. Watson <urchlay@slackware.uk>2023-12-15 21:11:58 -0500
committerB. Watson <urchlay@slackware.uk>2023-12-15 21:11:58 -0500
commit2ad13140d0a864c6cfdb614bb8f066ea701527f5 (patch)
tree6320b226aef5856d612ef251b49fd1dfd9560065
parentd221257bc87189a8a0e47e38ccd8de224cdb4754 (diff)
downloadsbo-maintainer-tools-2ad13140d0a864c6cfdb614bb8f066ea701527f5.tar.gz
sbopkglint: checks for /usr/share/terminfo.
-rw-r--r--TODO9
-rw-r--r--sbopkglint.d/05-basic-sanity.t.sh4
2 files changed, 4 insertions, 9 deletions
diff --git a/TODO b/TODO
index 5300183..b8e193d 100644
--- a/TODO
+++ b/TODO
@@ -4,16 +4,13 @@ DONE: if sbopkglint finds a hardcoded $PKG in /var/lib/pkgtools/scripts/*,
mention doinst.sh in the error message
DONE: check arch of static libs (like the shared lib checks).
DONE: if package contains any static libs, don't suggest noarch.
+DONE: check structure and contents of /usr/share/terminfo.
+DONE: /usr/share/pixmaps image check no longer includes subdirs.
Not yet implemented:
-TODO: don't complain about:
---- non-image files in icon dirs:
-[text/xml]: -rw-r--r-- 1 root root 11763 Oct 30 19:35 usr/share/pixmaps/pidgin/guifications/themes/default/theme.xml
TODO: stop checking shared libs for +x and being stripped if they're not
directly in /lib /lib64 /usr/lib /usr/lib64. too many packages
trigger this, and it just doesn't matter much.
-TODO: dereference symlinks in icon permission test. probably some other
- perms tests, too.
TODO: figure out if /usr/GNUstep is allowed or not.
TODO: sbopkglint reports bad files in doc dir twice.
TODO: sbopkglint should check for stuff like /usr/lib/lv2 vs. /usr/lib64/lv2,
@@ -23,8 +20,6 @@ TODO: sbopkglint could complain if the SlackBuild sets SLKCFLAGS
Future test ideas:
-- /usr/share/terminfo, light checking.
-
- duplicate files, maybe the error message could suggest a "ln -s" command
to use if the file really does need to appear in multiple dirs.
diff --git a/sbopkglint.d/05-basic-sanity.t.sh b/sbopkglint.d/05-basic-sanity.t.sh
index d799ab9..9119e60 100644
--- a/sbopkglint.d/05-basic-sanity.t.sh
+++ b/sbopkglint.d/05-basic-sanity.t.sh
@@ -43,14 +43,14 @@ fileonlydirs="$bindirs usr/man/man1 usr/man/man2 usr/man/man3 usr/man/man4 usr/m
# these directories may exist, but must contain only subdirectories
# (no files, symlinks, devices, etc). "." (the top-level package dir)
# doesn't need to be included here; it's checked separately.
-nofiledirs="usr usr/doc usr/share usr/man usr/doc/HTML"
+nofiledirs="usr usr/doc usr/share usr/man usr/doc/HTML usr/share/terminfo"
# these directories may exist but must not have executable files
# anywhere under them. I would put usr/doc and etc here, but too many
# packages break that rule. usr/share/applications is listed here,
# even though Slackware's KDE packages (erroneously) install .desktop
# files +x.
-noexecdirs="usr/include usr/man usr/share/pixmaps usr/share/icons usr/share/applications usr/share/appdata usr/share/mime usr/share/mime-info usr/share/glib-2.0 usr/doc/HTML"
+noexecdirs="usr/include usr/man usr/share/pixmaps usr/share/icons usr/share/applications usr/share/appdata usr/share/mime usr/share/mime-info usr/share/glib-2.0 usr/doc/HTML usr/share/terminfo"
# these files must exist, unless -s option given.
requiredfiles="usr/doc/$PRGNAM-$VERSION/$PRGNAM.SlackBuild"