diff options
| author | B. Watson <urchlay@slackware.uk> | 2023-06-30 06:06:18 -0400 |
|---|---|---|
| committer | B. Watson <urchlay@slackware.uk> | 2023-06-30 06:06:18 -0400 |
| commit | 8e1c2a8cbbfe67ca046cacb42d4e48de9b2b41c0 (patch) | |
| tree | 90c780fbf6244bd0b6122f45a7e063b5a31df757 | |
| parent | 95e4f0ecbcbe50a7d64e0347d590f62caaff53d5 (diff) | |
| download | sbo-maintainer-tools-8e1c2a8cbbfe67ca046cacb42d4e48de9b2b41c0.tar.gz | |
sbopkglint: do not require +x perm for 'no machine' ELF objects.
| -rw-r--r-- | TODO | 2 | ||||
| -rw-r--r-- | sbopkglint.d/20-arch.t.sh | 10 |
2 files changed, 10 insertions, 2 deletions
@@ -1,3 +1,5 @@ +TODO: sbopkglint should check for perllocal.pod, .packlist, *.bs + (see perl template). TODO: sbopkglint could complain if the SlackBuild sets SLKCFLAGS but there's no native code. diff --git a/sbopkglint.d/20-arch.t.sh b/sbopkglint.d/20-arch.t.sh index bb9fafe..462a3c6 100644 --- a/sbopkglint.d/20-arch.t.sh +++ b/sbopkglint.d/20-arch.t.sh @@ -38,8 +38,14 @@ if [ -n "$WRONGDIR" ]; then while read line; do file="$( echo $line | cut -d: -f1 )" filetype="$( echo $line | cut -d: -f2 )" + nomachine="$( echo $line | grep 'no machine' )" - [ ! -x "$file" ] && ls -bld "$file" >> .nonexec.$$ + # 20230630 bkw: don't require nomachine objects to be +x. + # AFAIK, the only thing that uses them is guile2.2, and it + # installs them 0644. + if [ ! "$nomachine" ]; then + [ ! -x "$file" ] && ls -bld "$file" >> .nonexec.$$ + fi case "$file" in # 20220414 bkw: only check for libs directly in the dir. @@ -69,7 +75,7 @@ if [ -n "$WRONGDIR" ]; then # don't check "no machine" ELF objects for being stripped. # our strip command doesn't know how to strip them! - if ! echo "$filetype" | grep -q 'no machine'; then + if [ ! "$nomachine" ]; then if echo "$filetype" | grep -q "not stripped"; then ls -lb "$file" >> .notstripped.$$ fi |