aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--TODO2
-rw-r--r--sbopkglint.d/20-arch.t.sh7
2 files changed, 7 insertions, 2 deletions
diff --git a/TODO b/TODO
index 18ceb8c..79b1c8e 100644
--- a/TODO
+++ b/TODO
@@ -1,4 +1,3 @@
-TODO: sbopkglint: exempt /lib/firmware and /usr/share/alsa/firmware from ELF checks
TODO: sbolint: exempt github gists URLs from check (actually, only check /archive/).
TODO: sbolint: complain about backticks and chown blah.blah
TODO: sbopkglint: maybe complain louder if an empty /usr/bin dir exists? aterm...
@@ -7,6 +6,7 @@ TODO: sbopkglint: maybe? change "forbidden" to:
TODO: sbopkglint: grep for LD_LIBRARY_PATH in /etc/profile.d/* scripts.
This stuff is implemented, probably works, needs more testing:
+TODO: sbopkglint: exempt /lib/firmware and /usr/share/alsa/firmware from ELF checks
DONE: sbolint and sbopkglint both: complain if PRGNAM has invalid characters.
DONE: if sbopkglint finds a hardcoded $PKG in /var/lib/pkgtools/scripts/*,
mention doinst.sh in the error message
diff --git a/sbopkglint.d/20-arch.t.sh b/sbopkglint.d/20-arch.t.sh
index 96bb120..bf6124e 100644
--- a/sbopkglint.d/20-arch.t.sh
+++ b/sbopkglint.d/20-arch.t.sh
@@ -33,7 +33,12 @@ esac
if [ -n "$WRONGDIR" ]; then
# 20230701 bkw: special case for /usr/share/qemu, it contains BIOS and such
# for emulated systems, some of which are ELF binaries.
- find * -type f -a \! -path usr/share/qemu/\* -print0 | \
+ # 20241008 bkw: special cases for firmware dirs.
+ find * -type f \
+ -a \! -path usr/share/qemu/\* \
+ -a \! -path usr/share/alsa/firmware/\* \
+ -a \! -path lib/firmware/\* \
+ -print0 | \
xargs -0 file -m /etc/file/magic/elf | \
grep 'ELF.*\(executable\|shared object\)' > .tmp.$$