aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--TODO7
-rwxr-xr-xsbolint2
2 files changed, 8 insertions, 1 deletions
diff --git a/TODO b/TODO
index f4f29f0..78505be 100644
--- a/TODO
+++ b/TODO
@@ -1,5 +1,12 @@
Missing argument in printf at /home/urchlay/bin/sbolint line 544, <$fh> line 2.
+TODO: sbolint: error if there are no files outside of install/ and the doc dir
+
+TODO: promote this to an error:
+___ note: package contains symlinks outside the package (which is OK, if intentional):
+lrwxrwxrwx 1 root root 99 May 23 18:14 ./usr/lib64/pidgin/libgowhatsapp.so -> /home/urchlay/sbodl-cache/libgowhatsapp_0.4.1~gitb84fdd7+gowhatsapp~git64cc8cf_amd64_ubuntu18.04.so
+...if the link target is /home/* or maybe if it's anything but /usr/*
+
TODO: sbopkglint fails to detect install-info, see pound @ 730a4ab1f9ee3162be2c6daf910c8b064e9169cb
TODO: sbolint should check for invalid characters in REQUIRES. someone
had an issue with a tab character, which looked fine when editing
diff --git a/sbolint b/sbolint
index 70e4f86..ba2df21 100755
--- a/sbolint
+++ b/sbolint
@@ -1313,7 +1313,7 @@ sub check_github_url {
$dir = $tag;
} elsif(@parts == 1) {
$tag = $dir = $parts[0];
- if($tag =~ /^[0-9a-f]{6,}$/ && $tag !~ /^20\d{6,}/) {
+ if($tag =~ /^[0-9a-f]{7,}$/ && $tag !~ /^20\d{6,}/) {
# commit hash. the /^20\d{6,}/ is to exclude ISO dates like 20240402
if(length($tag) < 40) {
# shortened, maybe the full hash is in the filename?