From 00c1756b4289365ca5a6c89896027446bdb57c02 Mon Sep 17 00:00:00 2001 From: "B. Watson" Date: Tue, 8 Oct 2024 23:53:26 -0400 Subject: sbolint: exempt github gists (and raw) URLs from check. --- TODO | 2 +- sbolint | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/TODO b/TODO index eecb7be..42a60f3 100644 --- a/TODO +++ b/TODO @@ -1,10 +1,10 @@ -TODO: sbolint: exempt github gists URLs from check (actually, only check /archive/). TODO: sbolint: complain about backticks and chown blah.blah TODO: sbopkglint: maybe? change "forbidden" to: --- etc/ld.so.conf not allowed to exist in SBo packages. TODO: sbopkglint: grep for LD_LIBRARY_PATH in /etc/profile.d/* scripts. This stuff is implemented, probably works, needs more testing: +TODO: sbolint: exempt github gists URLs from check (actually, only check /archive/). TODO: sbopkglint: complain louder if an empty /bin /usr/bin /sbin /usr/sbin exists. TODO: sbopkglint: exempt /lib/firmware and /usr/share/alsa/firmware from ELF checks DONE: sbolint and sbopkglint both: complain if PRGNAM has invalid characters. diff --git a/sbolint b/sbolint index fbb40f0..4da2afa 100755 --- a/sbolint +++ b/sbolint @@ -1239,7 +1239,9 @@ sub check_github_url { my $dir; # do not police releases/ or raw/ URLs, only archive/ - return unless $url =~ m{github\.com/[^/]*/[^/]*/archive/}; + # 20241008 bkw: also only police URLs that are in the main github.com + # domain, not e.g. raw.github.com or gists.github.com. + return unless $url =~ m{//github\.com/[^/]*/[^/]*/archive/}; # allow *and ignore* refs/tags $url =~ s,refs/tags/,,; -- cgit v1.2.3