From dedd4e4bdd5285d7270b7cad89aff3c9090f55ac Mon Sep 17 00:00:00 2001 From: "B. Watson" Date: Mon, 13 Feb 2023 17:13:37 -0500 Subject: sbolint: new PKGTYPE checks. --- sbolint | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/sbolint b/sbolint index 1debcda..ae90327 100755 --- a/sbolint +++ b/sbolint @@ -1211,6 +1211,9 @@ sub check_script { } elsif($cdpkg && /^[^#]*mkdir[^#]*install/) { $install = $lineno; } elsif(/^[^#]*makepkg/) { + if(/\$\{PKGTYPE:-/) { + log_error("$file:$lineno: makepkg PKGTYPE doesn't match 15.0 template"); + } if($makepkg) { log_error("$file:$lineno: makepkg called twice (here and line $makepkg"); } @@ -1241,6 +1244,9 @@ sub check_script { # 20230204 bkw: more 15.0 template if(/^PKGTYPE=/) { $pkg_type = $lineno; + if(not /:-tgz/) { + log_error("$file:$lineno: PKGTYPE doesn't default to tgz"); + } } if((not defined $arch_lineno) && (/\bARCH=/)) { -- cgit v1.2.3