From b86efd8389fa6b8e7d0974bf02c029474caeab8f Mon Sep 17 00:00:00 2001 From: "B. Watson" Date: Wed, 13 Dec 2023 02:32:07 -0500 Subject: sbopkglint: don't suggest noarch if package contains static libs. --- sbopkglint.d/15-noarch.t.sh | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) (limited to 'sbopkglint.d/15-noarch.t.sh') diff --git a/sbopkglint.d/15-noarch.t.sh b/sbopkglint.d/15-noarch.t.sh index 858b19e..075fdb1 100644 --- a/sbopkglint.d/15-noarch.t.sh +++ b/sbopkglint.d/15-noarch.t.sh @@ -10,15 +10,22 @@ # for packages that aren't noarch, recommend noarch if it looks like one. # the recommendation is not an error! +# shared libs and executables: find * -type f -print0 | xargs -0 file -m /etc/file/magic/elf | grep ELF | cut -d: -f1 | xargs -rd "\n" ls -lb > .elfbins.$$ +# static libs (for now, just going by filename!) +find * -type f -a -name '*.a' | xargs -rd "\n" ls -lb > .statlibs.$$ + if [ "$ARCH" = "noarch" ]; then [ -s .elfbins.$$ ] && \ warn "package claims to be noarch, but contains ELF binaries:" && \ cat .elfbins.$$ -elif [ ! -s .elfbins.$$ ] && [ ! -e usr/lib ] && [ ! -e usr/lib64 ]; then + [ -s .statlibs.$$ ] && \ + warn "package claims to be noarch, but contains static libraries:" && \ + cat .statlibs.$$ +elif [ ! -s .statlibs.$$ ] && [ ! -s .elfbins.$$ ] && [ ! -e usr/lib ] && [ ! -e usr/lib64 ]; then x="$( find usr/share/pkgconfig -type f -exec grep 'usr/lib' {} \+ 2>/dev/null )" [ -z "$x" ] && note "package might be a good candidate for noarch" fi -rm -f .elfbins.$$ +rm -f .elfbins.$$ .statlibs.$$ -- cgit v1.2.3