aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorB. Watson <urchlay@slackware.uk>2023-02-13 17:13:37 -0500
committerB. Watson <urchlay@slackware.uk>2023-02-13 17:13:37 -0500
commitdedd4e4bdd5285d7270b7cad89aff3c9090f55ac (patch)
treef7bb90b75f135e8418060cecc67c1a543a17d1c0
parent3ac66a0826f6808f2c7a561515b58ec3e43520e6 (diff)
downloadsbo-maintainer-tools-dedd4e4bdd5285d7270b7cad89aff3c9090f55ac.tar.gz
sbolint: new PKGTYPE checks.
-rwxr-xr-xsbolint6
1 files changed, 6 insertions, 0 deletions
diff --git a/sbolint b/sbolint
index 1debcda..ae90327 100755
--- a/sbolint
+++ b/sbolint
@@ -1211,6 +1211,9 @@ sub check_script {
} elsif($cdpkg && /^[^#]*mkdir[^#]*install/) {
$install = $lineno;
} elsif(/^[^#]*makepkg/) {
+ if(/\$\{PKGTYPE:-/) {
+ log_error("$file:$lineno: makepkg PKGTYPE doesn't match 15.0 template");
+ }
if($makepkg) {
log_error("$file:$lineno: makepkg called twice (here and line $makepkg");
}
@@ -1241,6 +1244,9 @@ sub check_script {
# 20230204 bkw: more 15.0 template
if(/^PKGTYPE=/) {
$pkg_type = $lineno;
+ if(not /:-tgz/) {
+ log_error("$file:$lineno: PKGTYPE doesn't default to tgz");
+ }
}
if((not defined $arch_lineno) && (/\bARCH=/)) {