aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorB. Watson <urchlay@slackware.uk>2023-09-16 17:01:00 -0400
committerB. Watson <urchlay@slackware.uk>2023-09-16 17:01:00 -0400
commit681722e1e340a5e931940eb9b09f9fc580cef02b (patch)
treed03e7262fd347cbbc802d12b3c5e9cf234f0bb16
parenta69bdc0ef63343373773995f7e87d11a29ed4259 (diff)
downloadsbo-maintainer-tools-681722e1e340a5e931940eb9b09f9fc580cef02b.tar.gz
sbopkglint: complain if anything is owned by UID or GID >= 1000.
-rw-r--r--TODO4
-rw-r--r--sbopkglint.d/05-basic-sanity.t.sh3
2 files changed, 3 insertions, 4 deletions
diff --git a/TODO b/TODO
index 8b6d1ef..a52beb9 100644
--- a/TODO
+++ b/TODO
@@ -1,7 +1,3 @@
-TODO: locale issues break the 'grep -P' in the info check. two
- things: (1) use a more reliable way to detect gz files, and
- (2) possibly force LANG and LC_* to "C". Or else en_US.UTF-8.
-TODO: check ownership of executables? fail if >1000 uid or gid?
TODO: if package contains any static libs, don't suggest noarch.
TODO: stop checking shared libs for +x and being stripped if they're not
directly in /lib /lib64 /usr/lib /usr/lib64. too many packages
diff --git a/sbopkglint.d/05-basic-sanity.t.sh b/sbopkglint.d/05-basic-sanity.t.sh
index 04d5ef9..d172cf9 100644
--- a/sbopkglint.d/05-basic-sanity.t.sh
+++ b/sbopkglint.d/05-basic-sanity.t.sh
@@ -201,3 +201,6 @@ find_warnfiles "package contains broken relative symlinks:" \
# we ignore any empty dirs under /var because lots of packages need these.
find_warnfiles --note "package contains empty dirs, are these necessary?" \
. -type d -a -empty -a \! -path "./var/*"
+
+find_warnfiles "package contains files owned by UID/GID >= 1000" \
+ . \( -uid +999 -o -gid +999 \)