sbolint: complain about chown with . instead of :

2 files changed, 7 insertions, 4 deletions

diff --git a/TODO b/TODO
index 42a60f3..dbb4159 100644
--- a/TODO
+++ b/TODO
@@ -1,12 +1,13 @@
-TODO: sbolint: complain about backticks and chown blah.blah
+TODO: sbolint: maybe? complain about backticks
 TODO: sbopkglint: maybe? change "forbidden" to:
   --- etc/ld.so.conf not allowed to exist in SBo packages.
 TODO: sbopkglint: grep for LD_LIBRARY_PATH in /etc/profile.d/* scripts.
 
 This stuff is implemented, probably works, needs more testing:
-TODO: sbolint: exempt github gists URLs from check (actually, only check /archive/).
-TODO: sbopkglint: complain louder if an empty /bin /usr/bin /sbin /usr/sbin exists.
-TODO: sbopkglint: exempt /lib/firmware and /usr/share/alsa/firmware from ELF checks
+DONE: sbolint: complain about chown blah.blah (should be blah:blah)
+DONE: sbolint: exempt github gists URLs from check (actually, only check /archive/).
+DONE: sbopkglint: complain louder if an empty /bin /usr/bin /sbin /usr/sbin exists.
+DONE: sbopkglint: exempt /lib/firmware and /usr/share/alsa/firmware from ELF checks
 DONE: sbolint and sbopkglint both: complain if PRGNAM has invalid characters.
 DONE: if sbopkglint finds a hardcoded $PKG in /var/lib/pkgtools/scripts/*,
       mention doinst.sh in the error message
diff --git a/sbolint b/sbolint
index 4da2afa..7d0ad72 100755
--- a/sbolint
+++ b/sbolint
@@ -1465,6 +1465,8 @@ sub check_script {
 			$makepkg = $lineno;
 		} elsif(/^\s*?CWD=/) {
 			log_warning("$file:$lineno: lone CWD= assignment is redundant in 15.0 template");
+		} elsif(/^\s*?chown\s+[^#;]*\S+\.\S+/) {
+			log_warning("$file:$lineno: chown should use : instead of . for user:group separator");
 		}
 
 		if(/^[^#]*<documentation>/) {